Re: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-28 Thread Linus Walleij
On Thu, Feb 28, 2013 at 2:51 AM, Joonyoung Shim wrote: > My mistake. If CONFIG_PINCTRL is disabled, devm_pinctrl_get_select_default > can return NULL. Yes, and that is perfectly legal and *NOT* an error. > devm_pinctrl_get_select() and pinctrl_get_select() also need IS_ERR_OR_NULL > instead of

Re: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-27 Thread Joonyoung Shim
Hi, On 02/21/2013 04:18 PM, Joonyoung Shim wrote: On 02/21/2013 04:12 PM, Vikas Sajjan wrote: Hi, On 21 February 2013 12:25, Joonyoung Shim wrote: Hi, On 02/15/2013 03:43 PM, Vikas Sajjan wrote: Add support for parsing the display-timing node using video helper function. The DT node par

Re: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-20 Thread Joonyoung Shim
On 02/21/2013 04:12 PM, Vikas Sajjan wrote: Hi, On 21 February 2013 12:25, Joonyoung Shim wrote: Hi, On 02/15/2013 03:43 PM, Vikas Sajjan wrote: Add support for parsing the display-timing node using video helper function. The DT node parsing and pinctrl selection is done only if 'dev.of_no

Re: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-20 Thread Vikas Sajjan
Hi, On 21 February 2013 12:25, Joonyoung Shim wrote: > Hi, > > > On 02/15/2013 03:43 PM, Vikas Sajjan wrote: >> >> Add support for parsing the display-timing node using video helper >> function. >> >> The DT node parsing and pinctrl selection is done only if 'dev.of_node' >> exists and the NON-DT

Re: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-20 Thread Joonyoung Shim
Hi, On 02/15/2013 03:43 PM, Vikas Sajjan wrote: Add support for parsing the display-timing node using video helper function. The DT node parsing and pinctrl selection is done only if 'dev.of_node' exists and the NON-DT logic is still maintained under the 'else' part. Signed-off-by: Leela Krish

Re: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-20 Thread Vikas Sajjan
er.kernel.org; kgene@samsung.com; >> inki@samsung.com; l.kris...@samsung.com; patc...@linaro.org >> Subject: [PATCH v6 1/1] video: drm: exynos: Add display-timing node >> parsing using video helper function >> >> Add support for parsing the display-timing node usi

RE: [PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-20 Thread Inki Dae
naro.org > Subject: [PATCH v6 1/1] video: drm: exynos: Add display-timing node > parsing using video helper function > > Add support for parsing the display-timing node using video helper > function. > > The DT node parsing and pinctrl selection is done only if 'dev.of_

[PATCH v6 1/1] video: drm: exynos: Add display-timing node parsing using video helper function

2013-02-14 Thread Vikas Sajjan
Add support for parsing the display-timing node using video helper function. The DT node parsing and pinctrl selection is done only if 'dev.of_node' exists and the NON-DT logic is still maintained under the 'else' part. Signed-off-by: Leela Krishna Amudala Signed-off-by: Vikas Sajjan --- drive