On 04/08/2013 12:36 PM, Guennadi Liakhovetski wrote:
> On Mon, 18 Mar 2013, Sylwester Nawrocki wrote:
>
> [snip]
>
>>> +unsigned long v4l2_clk_get_rate(struct v4l2_clk *clk)
>>> +{
>>> + if (!clk->ops->get_rate)
>>> + return -ENOSYS;
>>
>> I guess we should just WARN if this callback
On Mon, 18 Mar 2013, Sylwester Nawrocki wrote:
[snip]
> > +unsigned long v4l2_clk_get_rate(struct v4l2_clk *clk)
> > +{
> > + if (!clk->ops->get_rate)
> > + return -ENOSYS;
>
> I guess we should just WARN if this callback is null and return 0
> or return value type of this function n
Hi Guennadi,
On Tuesday 19 March 2013 11:27:56 Guennadi Liakhovetski wrote:
> On Tue, 19 Mar 2013, Sylwester Nawrocki wrote:
> > >>> + if (!IS_ERR(clk)&& !try_module_get(clk->ops->owner))
> > >>> + clk = ERR_PTR(-ENODEV);
> > >>> + mutex_unlock(&clk_lock);
> > >>> +
> >
Hello,
On Tuesday 19 March 2013 10:52:29 Sylwester Nawrocki wrote:
> On 03/19/2013 08:32 AM, Guennadi Liakhovetski wrote:
> > On Mon, 18 Mar 2013, Sylwester Nawrocki wrote:
> >> On 03/15/2013 10:27 PM, Guennadi Liakhovetski wrote:
> [...]
>
> >>> diff --git a/drivers/media/v4l2-core/v4l2-clk.c
>
Anatolij,
On Thu, Mar 21, 2013 at 2:40 PM, Anatolij Gustschin wrote:
> On Thu, 21 Mar 2013 13:49:50 +0530
> Prabhakar Lad wrote:
> ...
>> > drivers/media/v4l2-core/Makefile |2 +-
>> > drivers/media/v4l2-core/v4l2-clk.c | 184
>> >
>> > include/media
On Thu, 21 Mar 2013 13:49:50 +0530
Prabhakar Lad wrote:
...
> > drivers/media/v4l2-core/Makefile |2 +-
> > drivers/media/v4l2-core/v4l2-clk.c | 184
> >
> > include/media/v4l2-clk.h | 55 +++
> > 3 files changed, 240 insertions(+),
Hi Guennadi,
On Sat, Mar 16, 2013 at 2:57 AM, Guennadi Liakhovetski
wrote:
> Typical video devices like camera sensors require an external clock source.
> Many such devices cannot even access their hardware registers without a
> running clock. These clock sources should be controlled by their con
On Tue, 19 Mar 2013, Sylwester Nawrocki wrote:
> >>> + if (!IS_ERR(clk)&& !try_module_get(clk->ops->owner))
> >>> + clk = ERR_PTR(-ENODEV);
> >>> + mutex_unlock(&clk_lock);
> >>> +
> >>> + if (!IS_ERR(clk)) {
> >>> + clk->subdev = sd;
> >>
> >> Why is this needed ? It seems a stra
Hi Guennadi,
On 03/19/2013 08:32 AM, Guennadi Liakhovetski wrote:
> On Mon, 18 Mar 2013, Sylwester Nawrocki wrote:
>> On 03/15/2013 10:27 PM, Guennadi Liakhovetski wrote:
[...]
>>> diff --git a/drivers/media/v4l2-core/v4l2-clk.c
>>> b/drivers/media/v4l2-core/v4l2-clk.c
>>> new file mode 100644
>>>
Hi Sylwester
Thanks for reviewing.
On Mon, 18 Mar 2013, Sylwester Nawrocki wrote:
> Hi Guennadi,
>
> On 03/15/2013 10:27 PM, Guennadi Liakhovetski wrote:
> > Typical video devices like camera sensors require an external clock source.
> > Many such devices cannot even access their hardware regis
Hi Guennadi,
On 03/15/2013 10:27 PM, Guennadi Liakhovetski wrote:
Typical video devices like camera sensors require an external clock source.
Many such devices cannot even access their hardware registers without a
running clock. These clock sources should be controlled by their consumers.
This s
Typical video devices like camera sensors require an external clock source.
Many such devices cannot even access their hardware registers without a
running clock. These clock sources should be controlled by their consumers.
This should be performed, using the generic clock framework. Unfortunately
12 matches
Mail list logo
