Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-11-14 Thread Mark Brown
On Mon, Nov 14, 2016 at 02:18:49PM +0200, Laurent Pinchart wrote: > On Wednesday 26 Oct 2016 12:51:49 Mark Brown wrote: > > Why would this be guaranteed by the API given that it's not documented > > and why would many drivers break? It's fairly rare for devices other > > than SoCs to have strict

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-11-14 Thread Laurent Pinchart
Hi Mark, On Wednesday 26 Oct 2016 12:51:49 Mark Brown wrote: > On Wed, Oct 26, 2016 at 02:27:23PM +0300, Todor Tomov wrote: > > And using Mark Brown's correct address... > > This is an *enormous* e-mail quoted to multiple levels with top posting > and very little editing which makes it

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-10-27 Thread Todor Tomov
Hi, On 10/26/2016 07:48 PM, Ian Arkver wrote: > On 26/10/16 15:07, Todor Tomov wrote: >> Hi, >> >> On 10/26/2016 03:48 PM, Ian Arkver wrote: >>> [snip] > +static int ov5645_regulators_enable(struct ov5645 *ov5645) > +{ > +int ret; > + > +ret =

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-10-26 Thread Ian Arkver
On 26/10/16 15:07, Todor Tomov wrote: Hi, On 10/26/2016 03:48 PM, Ian Arkver wrote: [snip] +static int ov5645_regulators_enable(struct ov5645 *ov5645) +{ +int ret; + +ret = regulator_enable(ov5645->io_regulator); +if (ret < 0) { +dev_err(ov5645->dev, "set io voltage

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-10-26 Thread Todor Tomov
Hi, On 10/26/2016 03:48 PM, Ian Arkver wrote: > [snip] >>> +static int ov5645_regulators_enable(struct ov5645 *ov5645) >>> +{ >>> +int ret; >>> + >>> +ret = regulator_enable(ov5645->io_regulator); >>> +if (ret < 0) { >>> +dev_err(ov5645->dev, "set

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-10-26 Thread Ian Arkver
[snip] +static int ov5645_regulators_enable(struct ov5645 *ov5645) +{ + int ret; + + ret = regulator_enable(ov5645->io_regulator); + if (ret < 0) { + dev_err(ov5645->dev, "set io voltage failed\n"); + return ret; + } + + ret =

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-10-26 Thread Mark Brown
On Wed, Oct 26, 2016 at 02:27:23PM +0300, Todor Tomov wrote: > And using Mark Brown's correct address... This is an *enormous* e-mail quoted to multiple levels with top posting and very little editing which makes it incredibly hard to find any relevant content. > >> I believe it should be an

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-10-26 Thread Todor Tomov
And using Mark Brown's correct address... On 10/26/2016 02:15 PM, Todor Tomov wrote: > Hi, > > Adding Mark Brown in --to list. > > My reply on comments below. > The question on regulator bulk API to Mark Brown still holds. > > > On 10/19/2016 11:44 AM, Laurent Pinchart wrote: >> Hi Todor, >>

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-10-26 Thread Todor Tomov
Hi, Adding Mark Brown in --to list. My reply on comments below. The question on regulator bulk API to Mark Brown still holds. On 10/19/2016 11:44 AM, Laurent Pinchart wrote: > Hi Todor, > > (CC'ing Mark Brown for a question on regulators) > > On Friday 14 Oct 2016 14:57:01 Todor Tomov wrote:

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-10-19 Thread Laurent Pinchart
Hi Todor, (CC'ing Mark Brown for a question on regulators) On Friday 14 Oct 2016 14:57:01 Todor Tomov wrote: > Hi Laurent, > > Thank you for the time spent to do this thorough review of the patch! > > Below I have removed some of the comments where I agree and I'll fix. > I have left the

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-10-14 Thread Todor Tomov
Hi Laurent, Thank you for the time spent to do this thorough review of the patch! Below I have removed some of the comments where I agree and I'll fix. I have left the places where I have something relevant to say or ask. On 09/08/2016 03:22 PM, Laurent Pinchart wrote: > Hi Todor, > > Thank

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-09-08 Thread Laurent Pinchart
Hi Todor, Thank you for the patch. On Thursday 08 Sep 2016 12:13:55 Todor Tomov wrote: > The ov5645 sensor from Omnivision supports up to 2592x1944 > and CSI2 interface. > > The driver adds support for the following modes: > - 1280x960 > - 1920x1080 > - 2592x1944 > > Output format is packed

[PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

2016-09-08 Thread Todor Tomov
The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov --- drivers/media/i2c/Kconfig | 12 +