Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-11-27 Thread Mauro Carvalho Chehab
Em Fri, 23 Nov 2018 13:44:24 +0100 (CET) Thomas Gleixner escreveu: > On Fri, 23 Nov 2018, Mauro Carvalho Chehab wrote: > > Ok, I'll use then the enclosed patch, replacing them by a free > > form license info, adding a TODO at the end, as a reminder. > > LGTM. Thanks for fixing this. Thanks fo

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-11-25 Thread Tomasz Figa
On Fri, Nov 23, 2018 at 9:29 PM Mauro Carvalho Chehab wrote: > > Em Fri, 23 Nov 2018 11:38:37 +0100 (CET) > Thomas Gleixner escreveu: > > > Mauro, > > > > On Fri, 23 Nov 2018, Mauro Carvalho Chehab wrote: > > > > While we don't have it, we can't really use SPDX identifiers on media. > > > > So, r

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-11-23 Thread Thomas Gleixner
On Fri, 23 Nov 2018, Mauro Carvalho Chehab wrote: > Ok, I'll use then the enclosed patch, replacing them by a free > form license info, adding a TODO at the end, as a reminder. LGTM. Thanks for fixing this. tglx

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-11-23 Thread Mauro Carvalho Chehab
Em Fri, 23 Nov 2018 11:38:37 +0100 (CET) Thomas Gleixner escreveu: > Mauro, > > On Fri, 23 Nov 2018, Mauro Carvalho Chehab wrote: > > > While we don't have it, we can't really use SPDX identifiers on media. > > > So, replace them by a license text. > > > > > > Signed-off-by: Mauro Carvalho Cheh

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-11-23 Thread Thomas Gleixner
Mauro, On Fri, 23 Nov 2018, Mauro Carvalho Chehab wrote: > > While we don't have it, we can't really use SPDX identifiers on media. > > So, replace them by a license text. > > > > Signed-off-by: Mauro Carvalho Chehab > > > > diff --git a/Documentation/media/uapi/mediactl/media-ioc-request-alloc

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-11-23 Thread Mauro Carvalho Chehab
Thomas, Ping. Would the patch below work for you? Regards, Mauro Em Sun, 18 Nov 2018 11:52:15 -0200 Mauro Carvalho Chehab escreveu: > Hi Thomas, > > Em Mon, 12 Nov 2018 11:06:43 -0800 (PST) > Thomas Gleixner escreveu: > > > Folks, > > > > On Tue, 14 Aug 2018, Hans Verkuil wrote: > > > Fr

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-11-18 Thread Mauro Carvalho Chehab
Hi Thomas, Em Mon, 12 Nov 2018 11:06:43 -0800 (PST) Thomas Gleixner escreveu: > Folks, > > On Tue, 14 Aug 2018, Hans Verkuil wrote: > > From: Alexandre Courbot > > > > Document the request API for V4L2 devices, and amend the documentation > > of system calls influenced by it. > > > > Signed-

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-11-12 Thread Thomas Gleixner
Folks, On Tue, 14 Aug 2018, Hans Verkuil wrote: > From: Alexandre Courbot > > Document the request API for V4L2 devices, and amend the documentation > of system calls influenced by it. > > Signed-off-by: Alexandre Courbot > Signed-off-by: Hans Verkuil > Reviewed-by: Mauro Carvalho Chehab >

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-16 Thread Mauro Carvalho Chehab
Em Thu, 16 Aug 2018 11:58:09 +0200 Hans Verkuil escreveu: > >> This is set by the user when > >> calling > >> + :ref:`ioctl VIDIOC_QBUF ` and ignored by other ioctls. > > > > Shouldn't other ioctls return an error when V4L2_BUF_FLAG_REQUEST_FD is set > > ? > > Should they? I'd like to k

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-16 Thread Hans Verkuil
On 16/08/18 11:58, Hans Verkuil wrote: >>> +On success :c:func:`poll() ` returns the number of file >>> +descriptors that have been selected (that is, file descriptors for which >>> the +``revents`` field of the respective struct :c:type:`pollfd` >>> +is non-zero). Request file descriptor set the `

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-16 Thread Hans Verkuil
Hi Laurent, Thank you very much for your extensive review! On 15/08/18 18:14, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Tuesday, 14 August 2018 17:20:13 EEST Hans Verkuil wrote: >> +Description >> +=== >> + >> +If the media device supports :ref:`requests

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-15 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Tuesday, 14 August 2018 17:20:13 EEST Hans Verkuil wrote: > From: Alexandre Courbot > > Document the request API for V4L2 devices, and amend the documentation > of system calls influenced by it. > > Signed-off-by: Alexandre Courbot > Signed-off-by: Hans Ve

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 16:20:13 +0200 Hans Verkuil escreveu: > From: Alexandre Courbot > > Document the request API for V4L2 devices, and amend the documentation > of system calls influenced by it. Looks ok to me. Just a minor nitpick (see below). Mental note: we'll need to push the no-invariant

[PATCHv18 01/35] Documentation: v4l: document request API

2018-08-14 Thread Hans Verkuil
From: Alexandre Courbot Document the request API for V4L2 devices, and amend the documentation of system calls influenced by it. Signed-off-by: Alexandre Courbot Signed-off-by: Hans Verkuil --- .../media/uapi/mediactl/media-controller.rst | 1 + .../media/uapi/mediactl/media-funcs.rst