Re: [PATCHv2 1/2] v4l2-ioctl: simplify code

2016-04-13 Thread Mauro Carvalho Chehab
Em Wed, 13 Apr 2016 23:51:45 +0200 Hans Verkuil escreveu: > On 04/13/2016 09:57 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 21 Mar 2016 09:47:59 +0100 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Instead of a big if at the beginning, just check if g_selection == NULL > >

Re: [PATCHv2 1/2] v4l2-ioctl: simplify code

2016-04-13 Thread Hans Verkuil
On 04/13/2016 09:57 PM, Mauro Carvalho Chehab wrote: > Em Mon, 21 Mar 2016 09:47:59 +0100 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> Instead of a big if at the beginning, just check if g_selection == NULL >> and call the cropcap op immediately and return the result. >> >> No function

Re: [PATCHv2 1/2] v4l2-ioctl: simplify code

2016-04-13 Thread Mauro Carvalho Chehab
Em Mon, 21 Mar 2016 09:47:59 +0100 Hans Verkuil escreveu: > From: Hans Verkuil > > Instead of a big if at the beginning, just check if g_selection == NULL > and call the cropcap op immediately and return the result. > > No functional changes in this patch. Hmm... not true. See below. > > Si

[PATCHv2 1/2] v4l2-ioctl: simplify code

2016-03-21 Thread Hans Verkuil
From: Hans Verkuil Instead of a big if at the beginning, just check if g_selection == NULL and call the cropcap op immediately and return the result. No functional changes in this patch. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ioctl.c | 51