Re: [PATCHv2 5/8] [media] pvrusb2: initialize standards mask before detecting standard

2011-10-05 Thread Mike Isely
Mauro: With the line you've just added, then the = arg assignment in the immediate prior line is effectively dead code. Try this instead: case VIDIOC_QUERYSTD: { - v4l2_std_id *std = arg; + v4l2_std_id *std = V4L2_STD_ALL; ret =

Re: [PATCHv2 5/8] [media] pvrusb2: initialize standards mask before detecting standard

2011-10-05 Thread Mauro Carvalho Chehab
Em 05-10-2011 11:00, Mike Isely escreveu: Mauro: With the line you've just added, then the = arg assignment in the immediate prior line is effectively dead code. Try this instead: Look better: v4l2_std_id *std = arg; + *std = V4L2_STD_ALL; The above code

Re: [PATCHv2 5/8] [media] pvrusb2: initialize standards mask before detecting standard

2011-10-05 Thread Mike Isely
On Wed, 5 Oct 2011, Mauro Carvalho Chehab wrote: Em 05-10-2011 11:00, Mike Isely escreveu: Mauro: With the line you've just added, then the = arg assignment in the immediate prior line is effectively dead code. Try this instead: Look better: v4l2_std_id

[PATCHv2 5/8] [media] pvrusb2: initialize standards mask before detecting standard

2011-10-04 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com --- drivers/media/video/pvrusb2/pvrusb2-v4l2.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c index 0d029da..ce7ac45 100644