Re: [PATCHv3 15/15] media.h: reorganize header to make it easier to understand

2018-02-21 Thread Hans Verkuil
On 02/21/18 16:14, Sakari Ailus wrote: > Hi Hans, > > On Wed, Feb 21, 2018 at 03:33:03PM +0100, Hans Verkuil wrote: >> On 02/21/18 15:15, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Mon, Feb 19, 2018 at 11:38:06AM +0100, Hans Verkuil wrote: The media.h public header is very messy. It mixes le

Re: [PATCHv3 15/15] media.h: reorganize header to make it easier to understand

2018-02-21 Thread Sakari Ailus
Hi Hans, On Wed, Feb 21, 2018 at 03:33:03PM +0100, Hans Verkuil wrote: > On 02/21/18 15:15, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Feb 19, 2018 at 11:38:06AM +0100, Hans Verkuil wrote: > >> The media.h public header is very messy. It mixes legacy and 'new' defines > >> and it is not eas

Re: [PATCHv3 15/15] media.h: reorganize header to make it easier to understand

2018-02-21 Thread Hans Verkuil
On 02/21/18 15:15, Sakari Ailus wrote: > Hi Hans, > > On Mon, Feb 19, 2018 at 11:38:06AM +0100, Hans Verkuil wrote: >> The media.h public header is very messy. It mixes legacy and 'new' defines >> and it is not easy to figure out what should and what shouldn't be used. It >> also contains confusin

Re: [PATCHv3 15/15] media.h: reorganize header to make it easier to understand

2018-02-21 Thread Sakari Ailus
Hi Hans, On Mon, Feb 19, 2018 at 11:38:06AM +0100, Hans Verkuil wrote: > The media.h public header is very messy. It mixes legacy and 'new' defines > and it is not easy to figure out what should and what shouldn't be used. It > also contains confusing comment that are either out of date or complet

[PATCHv3 15/15] media.h: reorganize header to make it easier to understand

2018-02-19 Thread Hans Verkuil
The media.h public header is very messy. It mixes legacy and 'new' defines and it is not easy to figure out what should and what shouldn't be used. It also contains confusing comment that are either out of date or completely uninteresting for anyone that needs to use this header. The patch groups