Re: [PATCHv4] [media] rcar-vin: add Renesas R-Car VIN driver

2016-04-21 Thread Niklas Söderlund
On 2016-04-21 08:55:46 +0200, Hans Verkuil wrote: > On 04/12/2016 04:33 PM, Niklas Söderlund wrote: > > +static void rect_set_min_size(struct v4l2_rect *r, > > + const struct v4l2_rect *min_size) > > +{ > > + if (r->width < min_size->width) > > + r->width =

Re: [PATCHv4] [media] rcar-vin: add Renesas R-Car VIN driver

2016-04-21 Thread Hans Verkuil
On 04/12/2016 04:33 PM, Niklas Söderlund wrote: > +static void rect_set_min_size(struct v4l2_rect *r, > + const struct v4l2_rect *min_size) > +{ > + if (r->width < min_size->width) > + r->width = min_size->width; > + if (r->height < min_size->height) >

Re: [PATCHv4] [media] rcar-vin: add Renesas R-Car VIN driver

2016-04-18 Thread Hans Verkuil
Hi Niklas, Thanks for the patch. I've been testing this a bit more and there are a few things missing. On 04/12/2016 04:33 PM, Niklas Söderlund wrote: > diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c > b/drivers/media/platform/rcar-vin/rcar-v4l2.c > new file mode 100644 > index

[PATCHv4] [media] rcar-vin: add Renesas R-Car VIN driver

2016-04-12 Thread Niklas Söderlund
A V4L2 driver for Renesas R-Car VIN driver that do not depend on soc_camera. The driver is heavily based on its predecessor and aims to replace it. Signed-off-by: Niklas Söderlund --- The driver is tested on Koelsch and can do streaming using qv4l2 and