Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-16 Thread Trent Piepho
On Tue, 16 Jun 2009, Eduardo Valentin wrote: > On Sun, Jun 14, 2009 at 06:59:13PM +0200, ext Hans Verkuil wrote: > > On Sunday 14 June 2009 18:23:41 Trent Piepho wrote: > > > > > similar V4L2_CID_MPEG_EMPHASIS control and others might well appear > > > > > in the > > > > > future, so I think this

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-16 Thread Eduardo Valentin
On Tue, Jun 16, 2009 at 01:18:57PM +0200, ext Hans Verkuil wrote: > On Tuesday 16 June 2009 12:52:34 Eduardo Valentin wrote: > > > It is my believe that the other fm_tx controls are unambiguously > > > transmitter related, so I don't think they need a TX prefix. It doesn't > > > hurt if someone can

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-16 Thread Hans Verkuil
On Tuesday 16 June 2009 12:52:34 Eduardo Valentin wrote: > > It is my believe that the other fm_tx controls are unambiguously > > transmitter related, so I don't think they need a TX prefix. It doesn't > > hurt if someone can double check that, though. > > hmm.. I see no problem removing the fmtx p

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-16 Thread Eduardo Valentin
On Sun, Jun 14, 2009 at 06:59:13PM +0200, ext Hans Verkuil wrote: > On Sunday 14 June 2009 18:23:41 Trent Piepho wrote: > > On Sun, 14 Jun 2009, Eduardo Valentin wrote: > > > >> +/* FM Modulator class control IDs */ > > > >> +#define V4L2_CID_FM_TX_CLASS_BASE (V4L2_CTRL_CLASS_FM_TX | 0x900) >

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-14 Thread Hans Verkuil
On Sunday 14 June 2009 18:23:41 Trent Piepho wrote: > On Sun, 14 Jun 2009, Eduardo Valentin wrote: > > >> +/* FM Modulator class control IDs */ > > >> +#define V4L2_CID_FM_TX_CLASS_BASE (V4L2_CTRL_CLASS_FM_TX | 0x900) > > >> +#define V4L2_CID_FM_TX_CLASS                 (V4L2_CTRL_CLASS_FM_TX

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-14 Thread Trent Piepho
On Sun, 14 Jun 2009, Eduardo Valentin wrote: > >> +/* FM Modulator class control IDs */ > >> +#define V4L2_CID_FM_TX_CLASS_BASE (V4L2_CTRL_CLASS_FM_TX | 0x900) > >> +#define V4L2_CID_FM_TX_CLASS ? ? ? ? ? ? ? ? (V4L2_CTRL_CLASS_FM_TX | 1) > >> + > >> +#define V4L2_CID_RDS_ENABLED ? ? ? ? ? ? ?

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-14 Thread Eduardo Valentin
Hi Hans, On Sun, Jun 14, 2009 at 1:46 PM, Hans Verkuil wrote: > On Friday 12 June 2009 19:30:33 Eduardo Valentin wrote: >> This patch adds a new class of extended controls. This class >> is intended to support FM Radio Modulators properties such as: >> rds, audio limiters, audio compression, pilot

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-14 Thread Hans Verkuil
On Friday 12 June 2009 19:30:33 Eduardo Valentin wrote: > This patch adds a new class of extended controls. This class > is intended to support FM Radio Modulators properties such as: > rds, audio limiters, audio compression, pilot tone generation, > tuning power levels and preemphasis properties.

[PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-12 Thread Eduardo Valentin
This patch adds a new class of extended controls. This class is intended to support FM Radio Modulators properties such as: rds, audio limiters, audio compression, pilot tone generation, tuning power levels and preemphasis properties. Signed-off-by: Eduardo Valentin --- linux/include/linux/video