Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-13 Thread Russell King - ARM Linux
On Mon, Oct 12, 2015 at 02:39:42PM +0200, Hans Verkuil wrote: > On 10/12/2015 02:33 PM, Kamil Debski wrote: > > The possible status values that are implemented in the CEC framework > > are following: > > > > +/* cec status field */ > > +#define CEC_TX_STATUS_OK (0) > > +#define CEC_T

Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-12 Thread Kamil Debski
Hi, On 12 October 2015 at 14:39, Hans Verkuil wrote: > On 10/12/2015 02:33 PM, Kamil Debski wrote: >> Hi, >> >> On 12 October 2015 at 12:50, Hans Verkuil wrote: >>> On 10/06/2015 12:32 AM, Russell King - ARM Linux wrote: On Mon, Sep 07, 2015 at 03:44:43PM +0200, Hans Verkuil wrote: > +

Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-12 Thread Hans Verkuil
On 10/12/2015 02:33 PM, Kamil Debski wrote: > Hi, > > On 12 October 2015 at 12:50, Hans Verkuil wrote: >> On 10/06/2015 12:32 AM, Russell King - ARM Linux wrote: >>> On Mon, Sep 07, 2015 at 03:44:43PM +0200, Hans Verkuil wrote: +if (status & CEC_STATUS_TX_DONE) { +if (st

Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-12 Thread Kamil Debski
Hi, On 12 October 2015 at 12:50, Hans Verkuil wrote: > On 10/06/2015 12:32 AM, Russell King - ARM Linux wrote: >> On Mon, Sep 07, 2015 at 03:44:43PM +0200, Hans Verkuil wrote: >>> +if (status & CEC_STATUS_TX_DONE) { >>> +if (status & CEC_STATUS_TX_ERROR) { >>> +

Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-12 Thread Hans Verkuil
On 10/06/2015 01:11 AM, Russell King - ARM Linux wrote: > On Mon, Sep 07, 2015 at 03:44:43PM +0200, Hans Verkuil wrote: >> +cec->adap = cec_create_adapter(&s5p_cec_adap_ops, cec, >> +CEC_NAME, CEC_CAP_STATE | >> +CEC_CAP_PHYS_ADDR | CEC_CAP_LOG_ADDRS | CEC_CAP_IO | >> +

Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-12 Thread Hans Verkuil
On 10/06/2015 12:32 AM, Russell King - ARM Linux wrote: > On Mon, Sep 07, 2015 at 03:44:43PM +0200, Hans Verkuil wrote: >> +if (status & CEC_STATUS_TX_DONE) { >> +if (status & CEC_STATUS_TX_ERROR) { >> +dev_dbg(cec->dev, "CEC_STATUS_TX_ERROR set\n"); >> +

Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-05 Thread Russell King - ARM Linux
On Mon, Sep 07, 2015 at 03:44:43PM +0200, Hans Verkuil wrote: > + cec->adap = cec_create_adapter(&s5p_cec_adap_ops, cec, > + CEC_NAME, CEC_CAP_STATE | > + CEC_CAP_PHYS_ADDR | CEC_CAP_LOG_ADDRS | CEC_CAP_IO | > + CEC_CAP_IS_SOURCE, > + 0, THIS_MODU

Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-05 Thread Russell King - ARM Linux
On Mon, Sep 07, 2015 at 03:44:43PM +0200, Hans Verkuil wrote: > + if (status & CEC_STATUS_TX_DONE) { > + if (status & CEC_STATUS_TX_ERROR) { > + dev_dbg(cec->dev, "CEC_STATUS_TX_ERROR set\n"); > + cec->tx = STATE_ERROR; > + } else

[PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-09-07 Thread Hans Verkuil
From: Kamil Debski Add CEC interface driver present in the Samsung Exynos range of SoCs. The following files were based on work by SangPil Moon: - exynos_hdmi_cec.h - exynos_hdmi_cecctl.c Signed-off-by: Kamil Debski Signed-off-by: Hans Verkuil --- .../devicetree/bindings/media/s5p-cec.txt