Re: [Patch 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture driver

2015-09-16 Thread Benoit Parrot
Hans, I am almost done with my review comment but I am stuck here. Benoit Parrot wrote on Tue [2015-Jun-23 14:36:47 -0500]: > > > + > > > +static int cal_get_external_info(struct cal_ctx *ctx) > > > +{ > > > + struct v4l2_ext_control ctrl_ext; > > > + struct v4l2_ext_controls ctrls_ext; > > > +

Re: [Patch 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture driver

2015-06-23 Thread Benoit Parrot
Hans, Thanks for the feedback. Hans Verkuil wrote on Mon [2015-Jun-22 10:09:00 +0200]: > Hi Benoit, > > Thanks for the patch! I do have a few comments, though. See below. > > On 06/16/2015 07:29 PM, Benoit Parrot wrote: > > The Camera Adaptation Layer (CAL) is a block which consists of a dual

Re: [Patch 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture driver

2015-06-22 Thread Hans Verkuil
Hi Benoit, Thanks for the patch! I do have a few comments, though. See below. On 06/16/2015 07:29 PM, Benoit Parrot wrote: > The Camera Adaptation Layer (CAL) is a block which consists of a dual > port CSI2/MIPI camera capture engine. > Port #0 can handle CSI2 camera connected to up to 4 data lan

[Patch 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture driver

2015-06-16 Thread Benoit Parrot
The Camera Adaptation Layer (CAL) is a block which consists of a dual port CSI2/MIPI camera capture engine. Port #0 can handle CSI2 camera connected to up to 4 data lanes. Port #1 can handle CSI2 camera connected to up to 2 data lanes. The driver implements the required API/ioctls to be V4L2 compli