On 2018年06月01日 17:42, Sakari Ailus wrote:
On Fri, May 25, 2018 at 05:55:35PM +0800, bingbu@intel.com wrote:
+static int ak7375_i2c_write(struct ak7375_device *ak7375,
+ u8 addr, u16 data, int size)
+{
+ struct i2c_client *client = v4l2_get_subdevdata(&ak7375->sd);
+ int
On Fri, Jun 01, 2018 at 05:54:30PM +0800, Bing Bu Cao wrote:
> > > +AKM AK7375 LENS VOICE COIL DRIVER
> > > +M: Tianshu Qiu
> > > +L: linux-media@vger.kernel.org
> > > +T: git git://linuxtv.org/media_tree.git
> > > +S: Maintained
> > > +F: drivers/media/i2c/ak7375.c
>
On 2018年06月01日 17:34, Sakari Ailus wrote:
Hi Bingbu,
A few comments below.
On Fri, May 25, 2018 at 05:55:35PM +0800, bingbu@intel.com wrote:
From: Bingbu Cao
Add a V4L2 sub-device driver for the ak7375 lens voice coil.
This is a voice coil module using the I2C bus to control the
focus
On Fri, May 25, 2018 at 05:55:35PM +0800, bingbu@intel.com wrote:
> +static int ak7375_i2c_write(struct ak7375_device *ak7375,
> + u8 addr, u16 data, int size)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ak7375->sd);
> + int ret;
> + u8 buf[3];
> +
> + if (size
Hi Bingbu,
A few comments below.
On Fri, May 25, 2018 at 05:55:35PM +0800, bingbu@intel.com wrote:
> From: Bingbu Cao
>
> Add a V4L2 sub-device driver for the ak7375 lens voice coil.
> This is a voice coil module using the I2C bus to control the
> focus position.
>
> Signed-off-by: Tianshu
From: Bingbu Cao
Add a V4L2 sub-device driver for the ak7375 lens voice coil.
This is a voice coil module using the I2C bus to control the
focus position.
Signed-off-by: Tianshu Qiu
Signed-off-by: Bingbu Cao
---
MAINTAINERS| 8 ++
drivers/media/i2c/Kconfig | 10 ++
drivers