Re: [REVIEW PATCH 3/3] saa7134: convert to vb2

2014-04-18 Thread Devin Heitmueller
Hi Hans, > This makes no sense. The vivi driver uses vb2-vmalloc as well, and that works > perfectly fine in userptr mode. Applying this patch breaks vivi userptr mode, > so this is a NACK for this patch. Don't misunderstand, I acknowledge the very real possibility that I don't fully understand t

Re: [REVIEW PATCH 3/3] saa7134: convert to vb2

2014-04-18 Thread Hans Verkuil
Hi Devin, On 04/18/2014 03:49 PM, Devin Heitmueller wrote: >> This was a bit confusing following the previous paragraph. I meant to say >> that the >> *saa7134* userptr implementation is not USERPTR at all but >> PAGE_ALIGNED_USERPTR. >> >> A proper USERPTR implementation (like in bttv) can use

Re: [REVIEW PATCH 3/3] saa7134: convert to vb2

2014-04-18 Thread Devin Heitmueller
> This was a bit confusing following the previous paragraph. I meant to say > that the > *saa7134* userptr implementation is not USERPTR at all but > PAGE_ALIGNED_USERPTR. > > A proper USERPTR implementation (like in bttv) can use any malloc()ed pointer > as > it should, but saa7134 can't as it

Re: [REVIEW PATCH 3/3] saa7134: convert to vb2

2014-04-18 Thread Hans Verkuil
On 04/17/2014 03:13 PM, Mauro Carvalho Chehab wrote: > Em Thu, 17 Apr 2014 11:49:51 +0200 > Hans Verkuil escreveu: > >> On 04/17/2014 04:17 AM, Mauro Carvalho Chehab wrote: >>> Em Thu, 17 Apr 2014 00:33:55 +0200 >>> Hans Verkuil escreveu: >>> On 04/17/2014 12:23 AM, Mauro Carvalho Chehab wr

Re: [REVIEW PATCH 3/3] saa7134: convert to vb2

2014-04-17 Thread Mauro Carvalho Chehab
Em Thu, 17 Apr 2014 11:49:51 +0200 Hans Verkuil escreveu: > On 04/17/2014 04:17 AM, Mauro Carvalho Chehab wrote: > > Em Thu, 17 Apr 2014 00:33:55 +0200 > > Hans Verkuil escreveu: > > > >> On 04/17/2014 12:23 AM, Mauro Carvalho Chehab wrote: > >>> Em Mon, 10 Mar 2014 13:20:49 +0100 > >>> Hans Ve

Re: [REVIEW PATCH 3/3] saa7134: convert to vb2

2014-04-17 Thread Hans Verkuil
On 04/17/2014 04:17 AM, Mauro Carvalho Chehab wrote: > Em Thu, 17 Apr 2014 00:33:55 +0200 > Hans Verkuil escreveu: > >> On 04/17/2014 12:23 AM, Mauro Carvalho Chehab wrote: >>> Em Mon, 10 Mar 2014 13:20:49 +0100 >>> Hans Verkuil escreveu: >>> From: Hans Verkuil Convert the saa713

Re: [REVIEW PATCH 3/3] saa7134: convert to vb2

2014-04-16 Thread Mauro Carvalho Chehab
Em Thu, 17 Apr 2014 00:33:55 +0200 Hans Verkuil escreveu: > On 04/17/2014 12:23 AM, Mauro Carvalho Chehab wrote: > > Em Mon, 10 Mar 2014 13:20:49 +0100 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Convert the saa7134 driver to vb2. > >> > >> Note that while this uses the vb

Re: [REVIEW PATCH 3/3] saa7134: convert to vb2

2014-04-16 Thread Hans Verkuil
On 04/17/2014 12:23 AM, Mauro Carvalho Chehab wrote: > Em Mon, 10 Mar 2014 13:20:49 +0100 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> Convert the saa7134 driver to vb2. >> >> Note that while this uses the vb2-dma-sg version, the VB2_USERPTR mode is >> disabled. The DMA hardware only s