[REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Hans Verkuil
(Fixed typo pointed out by Pawel, but more importantly made an additional change to __qbuf_dmabuf. See last paragraph in the commit log) Sparse generated a bunch of errors like this: drivers/media/v4l2-core/videobuf2-core.c:2045:25: error: incompatible types in conditional expression

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Monday 17 March 2014 11:58:08 Hans Verkuil wrote: (Fixed typo pointed out by Pawel, but more importantly made an additional change to __qbuf_dmabuf. See last paragraph in the commit log) [snip] I made one other change: in __qbuf_dmabuf the result of the

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Hans Verkuil
On 03/17/2014 01:26 PM, Laurent Pinchart wrote: Hi Hans, Thank you for the patch. On Monday 17 March 2014 11:58:08 Hans Verkuil wrote: (Fixed typo pointed out by Pawel, but more importantly made an additional change to __qbuf_dmabuf. See last paragraph in the commit log) [snip] I

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Laurent Pinchart
Hi Hans, On Monday 17 March 2014 13:32:44 Hans Verkuil wrote: On 03/17/2014 01:26 PM, Laurent Pinchart wrote: On Monday 17 March 2014 11:58:08 Hans Verkuil wrote: (Fixed typo pointed out by Pawel, but more importantly made an additional change to __qbuf_dmabuf. See last paragraph in the

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Hans Verkuil
On 03/17/2014 01:41 PM, Laurent Pinchart wrote: Hi Hans, On Monday 17 March 2014 13:32:44 Hans Verkuil wrote: On 03/17/2014 01:26 PM, Laurent Pinchart wrote: On Monday 17 March 2014 11:58:08 Hans Verkuil wrote: (Fixed typo pointed out by Pawel, but more importantly made an additional

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Laurent Pinchart
Hi Hans, On Monday 17 March 2014 13:47:35 Hans Verkuil wrote: On 03/17/2014 01:41 PM, Laurent Pinchart wrote: On Monday 17 March 2014 13:32:44 Hans Verkuil wrote: On 03/17/2014 01:26 PM, Laurent Pinchart wrote: On Monday 17 March 2014 11:58:08 Hans Verkuil wrote: (Fixed typo pointed out

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Laurent Pinchart
Hi Hans, On Monday 17 March 2014 14:30:51 Hans Verkuil wrote: On 03/17/2014 02:27 PM, Laurent Pinchart wrote: On Monday 17 March 2014 13:47:35 Hans Verkuil wrote: On 03/17/2014 01:41 PM, Laurent Pinchart wrote: On Monday 17 March 2014 13:32:44 Hans Verkuil wrote: On 03/17/2014 01:26 PM,

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Hans Verkuil
On 03/17/2014 02:27 PM, Laurent Pinchart wrote: Hi Hans, On Monday 17 March 2014 13:47:35 Hans Verkuil wrote: On 03/17/2014 01:41 PM, Laurent Pinchart wrote: On Monday 17 March 2014 13:32:44 Hans Verkuil wrote: On 03/17/2014 01:26 PM, Laurent Pinchart wrote: On Monday 17 March 2014