Re: [RFC/PATCH] media: Add video bus switch

2016-12-24 Thread Pavel Machek
On Sat 2016-12-24 15:26:57, Pavel Machek wrote: > Hi! > > > > So... did I understood it correctly? (Needs some work to be done...) > > > > I had a quick look and yes, that's basically what I had in mind to > > solve the issue. If callback is not available the old system should > > be used of cour

Re: [RFC/PATCH] media: Add video bus switch

2016-12-24 Thread Pavel Machek
Hi! > > So... did I understood it correctly? (Needs some work to be done...) > > I had a quick look and yes, that's basically what I had in mind to > solve the issue. If callback is not available the old system should > be used of course. Ok, got it to work, thanks for all the help. I'll clean i

Re: [RFC/PATCH] media: Add video bus switch

2016-12-23 Thread Pavel Machek
Hi! Ok, this should be closer to something working. (But it does not work, yet). Pavel diff --git a/Documentation/devicetree/bindings/media/video-bus-switch.txt b/Doc

Re: [RFC/PATCH] media: Add video bus switch

2016-12-23 Thread Ivaylo Dimitrov
Hi, On 23.12.2016 13:42, Pavel Machek wrote: Hi! [...] static int isp_subdev_notifier_bound(struct v4l2_async_notifier *async, diff --git a/drivers/media/platform/video-bus-switch.c b/drivers/media/platform/video-bus-switch.c index 1a5d944..3a2d442 100644 --- a/drivers/media/platform/video-

Re: [RFC/PATCH] media: Add video bus switch

2016-12-23 Thread Pavel Machek
Hi! > > [...] > > > > static int isp_subdev_notifier_bound(struct v4l2_async_notifier *async, > > diff --git a/drivers/media/platform/video-bus-switch.c > > b/drivers/media/platform/video-bus-switch.c > > index 1a5d944..3a2d442 100644 > > --- a/drivers/media/platform/video-bus-switch.c > > +++ b

Re: [RFC/PATCH] media: Add video bus switch

2016-12-22 Thread Sebastian Reichel
Hi, On Thu, Dec 22, 2016 at 11:42:26PM +0100, Pavel Machek wrote: > On Thu 2016-12-22 15:32:44, Sebastian Reichel wrote: > > Hi Pavel, > > > > On Thu, Dec 22, 2016 at 02:39:38PM +0100, Pavel Machek wrote: > > > N900 contains front and back camera, with a switch between the > > > two. This adds su

Re: [RFC/PATCH] media: Add video bus switch

2016-12-22 Thread Sebastian Reichel
Hi, On Thu, Dec 22, 2016 at 09:53:17PM +0100, Pavel Machek wrote: > > 1. Settings must be applied before the streaming starts instead of > > at probe time, since the settings may change (based one the selected > > camera). That should be fairly easy to implement by just moving the > > code to the

Re: [RFC/PATCH] media: Add video bus switch

2016-12-22 Thread Pavel Machek
On Thu 2016-12-22 15:32:44, Sebastian Reichel wrote: > Hi Pavel, > > On Thu, Dec 22, 2016 at 02:39:38PM +0100, Pavel Machek wrote: > > N900 contains front and back camera, with a switch between the > > two. This adds support for the swich component. > > > > Signed-off-by: Sebastian Reichel > > S

Re: [RFC/PATCH] media: Add video bus switch

2016-12-22 Thread Pavel Machek
Hi! > > I see this needs dts documentation, anything else than needs to be > > done? > > Yes. This driver takes care of the switch gpio, but the cameras also > use different bus settings. Currently omap3isp gets the bus-settings > from the link connected to the CCP2 port in DT at probe time (*).

Re: [RFC/PATCH] media: Add video bus switch

2016-12-22 Thread Sebastian Reichel
Hi Pavel, On Thu, Dec 22, 2016 at 02:39:38PM +0100, Pavel Machek wrote: > N900 contains front and back camera, with a switch between the > two. This adds support for the swich component. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Ivaylo Dimitrov > Signed-off-by: Pavel Machek > > --

[RFC/PATCH] media: Add video bus switch

2016-12-22 Thread Pavel Machek
N900 contains front and back camera, with a switch between the two. This adds support for the swich component. Signed-off-by: Sebastian Reichel Signed-off-by: Ivaylo Dimitrov Signed-off-by: Pavel Machek -- I see this needs dts documentation, anything else than needs to be done? Thanks,