Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-31 Thread Guennadi Liakhovetski
On Thu, 26 Jul 2012, Laurent Pinchart wrote: Hi Sylwester, On Tuesday 17 July 2012 20:16:23 Sylwester Nawrocki wrote: On 07/16/2012 10:55 AM, Guennadi Liakhovetski wrote: Hi Sylwester Thanks for your comments to my RFC and for pointing out to this your earlier patch series.

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-31 Thread Guennadi Liakhovetski
On Fri, 27 Jul 2012, Laurent Pinchart wrote: Hi Sylwester, On Thursday 26 July 2012 21:51:30 Sylwester Nawrocki wrote: On 07/26/2012 04:38 PM, Laurent Pinchart wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/video/mipi.txt @@ -0,0 +1,5 @@ +Common properties of

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-31 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 31 July 2012 12:58:50 Guennadi Liakhovetski wrote: On Fri, 27 Jul 2012, Laurent Pinchart wrote: On Thursday 26 July 2012 21:51:30 Sylwester Nawrocki wrote: On 07/26/2012 04:38 PM, Laurent Pinchart wrote: --- /dev/null +++

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-31 Thread Sylwester Nawrocki
On 07/31/2012 01:05 PM, Laurent Pinchart wrote: What about CSI receivers that can reroute the lanes internally ? We would need to specify lane indices for each lane then, maybe with something like clock-lane =0; data-lanes =2 3 1; Sounds good to me. And the clock-lane could be made

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-31 Thread Laurent Pinchart
Hi Sylwester, On Tuesday 31 July 2012 14:38:35 Sylwester Nawrocki wrote: On 07/31/2012 01:05 PM, Laurent Pinchart wrote: What about CSI receivers that can reroute the lanes internally ? We would need to specify lane indices for each lane then, maybe with something like clock-lane =0;

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Tuesday 17 July 2012 20:16:23 Sylwester Nawrocki wrote: On 07/16/2012 10:55 AM, Guennadi Liakhovetski wrote: Hi Sylwester Thanks for your comments to my RFC and for pointing out to this your earlier patch series. Unfortunately, I missed in in May, let me try to

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-26 Thread Sylwester Nawrocki
Hi Laurent, On 07/26/2012 04:38 PM, Laurent Pinchart wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/video/mipi.txt @@ -0,0 +1,5 @@ +Common properties of MIPI-CSI1 and MIPI-CSI2 receivers and transmitters + + - data-lanes : number of differential data lanes wired and actively

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Thursday 26 July 2012 21:51:30 Sylwester Nawrocki wrote: On 07/26/2012 04:38 PM, Laurent Pinchart wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/video/mipi.txt @@ -0,0 +1,5 @@ +Common properties of MIPI-CSI1 and MIPI-CSI2 receivers and transmitters +

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-17 Thread Sylwester Nawrocki
Hi Guennadi, On 07/16/2012 10:55 AM, Guennadi Liakhovetski wrote: Hi Sylwester Thanks for your comments to my RFC and for pointing out to this your earlier patch series. Unfortunately, I missed in in May, let me try to provide some thoughts about this, we should really try to converge our

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-16 Thread Guennadi Liakhovetski
Hi Sylwester Thanks for your comments to my RFC and for pointing out to this your earlier patch series. Unfortunately, I missed in in May, let me try to provide some thoughts about this, we should really try to converge our proposals. Maybe a discussion at KS would help too. On Fri, 25 May

[RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-05-25 Thread Sylwester Nawrocki
s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC (camera host interface DMA engine and image processor). This patch adds support for instantiating the MIPI-CSIS devices from DT and parsing all SoC and board specific properties from device tree. The MIPI DPHY control callback is