Re: [RFC] Cropping and scaling with subdev pad-level operations

2011-01-19 Thread Sakari Ailus
Hi Hans, others, Hans Verkuil wrote: > Hi Laurent, > > My apologies that this reply is so late, but I knew I had to sit down and > think > carefully about this and I didn't have time for that until today. > > I've decided not to quote your post but instead restate the problem in my own > words.

Re: [RFC] Cropping and scaling with subdev pad-level operations

2011-01-14 Thread Hans Verkuil
Hi Laurent, My apologies that this reply is so late, but I knew I had to sit down and think carefully about this and I didn't have time for that until today. I've decided not to quote your post but instead restate the problem in my own words. Seen abstractly you have an entity with inputs, outpu

Re: [RFC] Cropping and scaling with subdev pad-level operations

2011-01-12 Thread Laurent Pinchart
Hi Sylwester, On Wednesday 12 January 2011 00:31:26 Sylwester Nawrocki wrote: > On 01/06/2011 04:33 PM, Laurent Pinchart wrote: [snip] > > When the stream is off, we have two options: > > > > - Handle crop rectangle modifications the same way as when the stream is > > on. This is cleaner, but b

Re: [RFC] Cropping and scaling with subdev pad-level operations

2011-01-12 Thread Laurent Pinchart
Hi, On Tuesday 11 January 2011 20:06:52 Eino-Ville Talvala wrote: > On 1/6/2011 7:33 AM, Laurent Pinchart wrote: > > Hi everybody, > > ... > > > The OMAP3 ISP resizer currently implements the second option, and I'll > > modify it to implement the first option. The drawback is that some > > crop/

Re: [RFC] Cropping and scaling with subdev pad-level operations

2011-01-11 Thread Eino-Ville Talvala
On 1/6/2011 7:33 AM, Laurent Pinchart wrote: Hi everybody, ... The OMAP3 ISP resizer currently implements the second option, and I'll modify it to implement the first option. The drawback is that some crop/output combinations will require an extra step to be achieved. I'd like your opinion on t

Re: [RFC] Cropping and scaling with subdev pad-level operations

2011-01-11 Thread Sylwester Nawrocki
Hi Laurent, On 01/06/2011 04:33 PM, Laurent Pinchart wrote: > Hi everybody, > > I ran into an issue when implementing cropping and scaling on the OMAP3 ISP > resizer sub-device using the pad-level operations. As nobody seems to be happy > with the V4L2 crop ioctls, I thought I would ask for comm

Re: [RFC] Cropping and scaling with subdev pad-level operations

2011-01-07 Thread Laurent Pinchart
Hi Andy, On Thursday 06 January 2011 19:28:56 Andy Walls wrote: > On Thu, 2011-01-06 at 16:33 +0100, Laurent Pinchart wrote: > > Hi everybody, > > > > I ran into an issue when implementing cropping and scaling on the OMAP3 > > ISP resizer sub-device using the pad-level operations. As nobody seems

Re: [RFC] Cropping and scaling with subdev pad-level operations

2011-01-06 Thread Andy Walls
On Thu, 2011-01-06 at 16:33 +0100, Laurent Pinchart wrote: > Hi everybody, > > I ran into an issue when implementing cropping and scaling on the OMAP3 ISP > resizer sub-device using the pad-level operations. As nobody seems to be > happy > with the V4L2 crop ioctls, I thought I would ask for co

[RFC] Cropping and scaling with subdev pad-level operations

2011-01-06 Thread Laurent Pinchart
Hi everybody, I ran into an issue when implementing cropping and scaling on the OMAP3 ISP resizer sub-device using the pad-level operations. As nobody seems to be happy with the V4L2 crop ioctls, I thought I would ask for comments about the subdev pad-level API to avoid repeating the same mista