Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-08-20 Thread Hans Verkuil
On 08/20/15 00:19, Laurent Pinchart wrote: > Hi Hans, > > I like your proposal, and especially how it would integrate with the requests > API. Should we give the requests API a try to make sure your proposal works > fine with it ? To be honest, I don't see what there is to test. Request IDs hav

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-08-19 Thread Laurent Pinchart
Hi Hans, I like your proposal, and especially how it would integrate with the requests API. Should we give the requests API a try to make sure your proposal works fine with it ? As a side note, I'll need to requests API for Renesas. The current schedule is to have a first RFC implementation by

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-08-19 Thread Ricardo Ribalda Delgado
ping? On Mon, Aug 10, 2015 at 2:04 PM, Ricardo Ribalda Delgado wrote: > Hello Hans, Sakari and Laurent: > > I am back from holidays :). Shall I prepare a new patchset with the > suggestion from Hans? > > Thanks! > > On Mon, Jul 20, 2015 at 4:31 PM, Hans Verkuil wrote: >> On 07/20/2015 03:52 PM,

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-08-10 Thread Ricardo Ribalda Delgado
Hello Hans, Sakari and Laurent: I am back from holidays :). Shall I prepare a new patchset with the suggestion from Hans? Thanks! On Mon, Jul 20, 2015 at 4:31 PM, Hans Verkuil wrote: > On 07/20/2015 03:52 PM, Ricardo Ribalda Delgado wrote: >> Hello >> >> I have no preference over the two implem

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-07-20 Thread Hans Verkuil
On 07/20/2015 03:52 PM, Ricardo Ribalda Delgado wrote: > Hello > > I have no preference over the two implementations, but I see an issue > with this suggestion. > > > What happens to out out tree drivers, or drivers that don't support > this functionality? > > With the ioctl, the user receives

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-07-20 Thread Ricardo Ribalda Delgado
Hello I have no preference over the two implementations, but I see an issue with this suggestion. What happens to out out tree drivers, or drivers that don't support this functionality? With the ioctl, the user receives a -ENOTTY. So he knows there is something wrong with the driver. With this

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-07-20 Thread Hans Verkuil
On 06/12/2015 06:46 PM, Ricardo Ribalda Delgado wrote: > This ioctl returns the default value of one or more extended controls. > It has the same interface as VIDIOC_EXT_CTRLS. > > It is needed due to the fact that QUERYCTRL was not enough to > provide the initial value of pointer type controls.

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-07-17 Thread Ricardo Ribalda Delgado
Hi Sakari Thanks for your review! On Fri, Jul 17, 2015 at 9:13 AM, Sakari Ailus wrote: >> #define VIDIOC_QUERY_EXT_CTRL_IOWR('V', 103, struct >> v4l2_query_ext_ctrl) >> +#define VIDIOC_G_DEF_EXT_CTRLS _IOWR('V', 104, struct >> v4l2_ext_controls) > > I assume that if an applicat

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-07-17 Thread Hans Verkuil
On 07/17/2015 09:13 AM, Sakari Ailus wrote: > Hi Ricardo, > > Thanks for the set, and my apologies for the late review! > > On Fri, Jun 12, 2015 at 06:46:21PM +0200, Ricardo Ribalda Delgado wrote: >> This ioctl returns the default value of one or more extended controls. >> It has the same interfa

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-07-17 Thread Sakari Ailus
Hi Ricardo, Thanks for the set, and my apologies for the late review! On Fri, Jun 12, 2015 at 06:46:21PM +0200, Ricardo Ribalda Delgado wrote: > This ioctl returns the default value of one or more extended controls. > It has the same interface as VIDIOC_EXT_CTRLS. > > It is needed due to the fac

[RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-06-12 Thread Ricardo Ribalda Delgado
This ioctl returns the default value of one or more extended controls. It has the same interface as VIDIOC_EXT_CTRLS. It is needed due to the fact that QUERYCTRL was not enough to provide the initial value of pointer type controls. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-c