Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-14 Thread Arvydas Sidorenko
On Thu, Feb 14, 2013 at 8:12 AM, Hans Verkuil hverk...@xs4all.nl wrote: Arvydas, can you please test this? I'd like to do a git pull tomorrow and I'd like to know if the upside-down changes are now OK. Thanks, Hi Hans Everything is working fine now - dmesg is clean, LED lights on and off

Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-13 Thread Hans Verkuil
On Tue February 12 2013 09:28:55 Hans Verkuil wrote: On Mon February 11 2013 16:32:58 Arvydas Sidorenko wrote: On Mon, Feb 11, 2013 at 2:21 PM, Hans Verkuil hverk...@xs4all.nl wrote: That doesn't make sense either. Arvydas, it worked fine for you before, right? That is, if you use

Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-12 Thread Hans Verkuil
On Mon February 11 2013 16:32:58 Arvydas Sidorenko wrote: On Mon, Feb 11, 2013 at 2:21 PM, Hans Verkuil hverk...@xs4all.nl wrote: That doesn't make sense either. Arvydas, it worked fine for you before, right? That is, if you use e.g. v3.8-rc7 then your picture is the right side up.

Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-12 Thread Hans Verkuil
On Sun February 10 2013 18:52:42 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This resulted in an upside-down picture. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Tested-by: Arvydas Sidorenko asi...@gmail.com As mentioned in this thread, this patch was wrong. It's

Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-11 Thread Hans de Goede
Hi, Subject: stk-webcam: the initial hflip and vflip setup was the wrong way around No it is not. On 02/10/2013 06:52 PM, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This resulted in an upside-down picture. No it does not, the laptop having an upside down mounted camera

Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-11 Thread Hans de Goede
Hi, On 02/11/2013 02:21 PM, Hans Verkuil wrote: On Mon February 11 2013 14:08:44 Hans de Goede wrote: Hi, Subject: stk-webcam: the initial hflip and vflip setup was the wrong way around No it is not. You are right, that patch makes no sense. It was a long day :-) On 02/10/2013 06:52 PM,

Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-11 Thread Hans Verkuil
On Mon February 11 2013 14:41:08 Hans de Goede wrote: Hi, On 02/11/2013 02:21 PM, Hans Verkuil wrote: On Mon February 11 2013 14:08:44 Hans de Goede wrote: Hi, Subject: stk-webcam: the initial hflip and vflip setup was the wrong way around No it is not. You are right, that

Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-11 Thread Hans de Goede
Hi, On 02/11/2013 02:51 PM, Hans Verkuil wrote: On Mon February 11 2013 14:41:08 Hans de Goede wrote: Hi, On 02/11/2013 02:21 PM, Hans Verkuil wrote: On Mon February 11 2013 14:08:44 Hans de Goede wrote: Hi, Subject: stk-webcam: the initial hflip and vflip setup was the wrong way around

Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-11 Thread Anca Emanuel
I think the driver is not up to standard: look at the error messages. And there are a lot of to do because of lack of documentation. On Mon, Feb 11, 2013 at 4:55 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 02/11/2013 02:51 PM, Hans Verkuil wrote: On Mon February 11 2013 14:41:08

Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-11 Thread Arvydas Sidorenko
On Mon, Feb 11, 2013 at 2:21 PM, Hans Verkuil hverk...@xs4all.nl wrote: That doesn't make sense either. Arvydas, it worked fine for you before, right? That is, if you use e.g. v3.8-rc7 then your picture is the right side up. It is upside down using any v3.7.x or v3.8-rc7. I didn't pay

[RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This resulted in an upside-down picture. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Tested-by: Arvydas Sidorenko asi...@gmail.com --- drivers/media/usb/stkwebcam/stk-webcam.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff