Re: [RFT 1/2] [media] exynos4-is: Add missing endpoint of_node_put on error paths

2016-03-13 Thread Krzysztof Kozlowski
On 11.03.2016 21:30, Sylwester Nawrocki wrote: > On 01/26/2016 01:41 AM, Krzysztof Kozlowski wrote: >> In fimc_md_parse_port_node() endpoint node is get with of_get_next_child() >> but it is not put on error path. > > "is get" doesn't sound right to me, how about rephrasing this to: > > "In fimc_

Re: [RFT 1/2] [media] exynos4-is: Add missing endpoint of_node_put on error paths

2016-03-11 Thread Sylwester Nawrocki
On 01/26/2016 01:41 AM, Krzysztof Kozlowski wrote: > In fimc_md_parse_port_node() endpoint node is get with of_get_next_child() > but it is not put on error path. "is get" doesn't sound right to me, how about rephrasing this to: "In fimc_md_parse_port_node() reference count of the endpoint node "

Re: [RFT 1/2] [media] exynos4-is: Add missing endpoint of_node_put on error paths

2016-03-07 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/25/2016 09:41 PM, Krzysztof Kozlowski wrote: > In fimc_md_parse_port_node() endpoint node is get with of_get_next_child() > but it is not put on error path. > > Fixes: 56fa1a6a6a7d ("[media] s5p-fimc: Change the driver directory name to > exynos4-is") > Signed-off-by: Krzy