Re: [bug report] media: i2c: Copy tw9910 soc_camera sensor driver

2018-03-05 Thread Dan Carpenter
On Mon, Mar 05, 2018 at 09:51:48AM +0100, jacopo mondi wrote: > In your suggested fix: > > > (((vdelay >> 8) & 0x3) << 6) | > > (((vact >> 8) & 0x3) << 4) | > > (((hedelay >> 8) & 0x3) << 2) | > > ((hact >> 8) & 0x03); > > > > Won't your analyzer in that case point out that > "15

Re: [bug report] media: i2c: Copy tw9910 soc_camera sensor driver

2018-03-05 Thread jacopo mondi
Hi Dan, On Mon, Mar 05, 2018 at 10:21:09AM +0300, Dan Carpenter wrote: > On Fri, Mar 02, 2018 at 03:20:16PM +0100, jacopo mondi wrote: > > Hi Dan, > > > > On Thu, Mar 01, 2018 at 12:59:54PM +0300, Dan Carpenter wrote: > > > [ I know you're just copying files, but you might have a fix for these > >

Re: [bug report] media: i2c: Copy tw9910 soc_camera sensor driver

2018-03-04 Thread Dan Carpenter
On Fri, Mar 02, 2018 at 03:20:16PM +0100, jacopo mondi wrote: > Hi Dan, > > On Thu, Mar 01, 2018 at 12:59:54PM +0300, Dan Carpenter wrote: > > [ I know you're just copying files, but you might have a fix for these > > since you're looking at the code. - dan ] > > According to the static analyz

Re: [bug report] media: i2c: Copy tw9910 soc_camera sensor driver

2018-03-02 Thread jacopo mondi
Hi Dan, On Thu, Mar 01, 2018 at 12:59:54PM +0300, Dan Carpenter wrote: > [ I know you're just copying files, but you might have a fix for these > since you're looking at the code. - dan ] According to the static analyzer I should simply substitute all those expressions with 0s. I would instead

[bug report] media: i2c: Copy tw9910 soc_camera sensor driver

2018-03-01 Thread Dan Carpenter
[ I know you're just copying files, but you might have a fix for these since you're looking at the code. - dan ] Hello Jacopo Mondi, The patch e0d76c3842ee: "media: i2c: Copy tw9910 soc_camera sensor driver" from Feb 21, 2018, leads to the following static checker warning: drivers/media/i