Re: [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-19 Thread SF Markus Elfring
>> * How do you think about to avoid a variable assignment in case >> that this memory allocation failed anyhow? > > There is no memory allocation that can fail at this point. Do you really know the failure probability for a call of the function "kmalloc" (within the function "wbcir_tx") under

Re: [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-19 Thread SF Markus Elfring
>> Move the assignment for the local variable "data" behind the source code >> for a memory allocation by this function. > > Sorry, I can't see what the point is? * How do you think about to avoid a variable assignment in case that this memory allocation failed anyhow? * Do you care for data

Re: [PATCH 2/5] [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-19 Thread David Härdeman
October 14, 2016 1:42 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 07:34:46 +0200 > > Move the assignment for the local variable "data" behind the source code > for a memory allocation by this

Re: [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-19 Thread David Härdeman
October 19, 2016 3:32 PM, "SF Markus Elfring" wrote: >>> Move the assignment for the local variable "data" behind the source code >>> for a memory allocation by this function. >> >> Sorry, I can't see what the point is? > > * How do you think about to avoid a

[PATCH 2/5] [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-14 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 14 Oct 2016 07:34:46 +0200 Move the assignment for the local variable "data" behind the source code for a memory allocation by this function. Signed-off-by: Markus Elfring ---