Re: [patch] [media] cx18: check for allocation failure in cx18_read_eeprom()

2013-11-22 Thread Andy Walls
On Fri, 2013-11-22 at 10:21 +0100, Hans Verkuil wrote: > Andy, > > Should we perhaps change the MAINTAINERS file to point to the linux-media list > instead? Yes. When I get time this weekend, I can submit a patch; unless you beat me to it. Regards, Andy > Regards, > > Hans > > On 11/22

Re: [patch] [media] cx18: check for allocation failure in cx18_read_eeprom()

2013-11-22 Thread Andy Walls
On Fri, 2013-11-22 at 10:51 +0300, Dan Carpenter wrote: > It upsets static checkers when we don't check for allocation failure. I > moved the memset() of "tv" earlier so we don't use uninitialized data on > error. > > Fixes: 1d212cf0c2d8 ('[media] cx18: struct i2c_client is too big for stack') >

Re: [patch] [media] cx18: check for allocation failure in cx18_read_eeprom()

2013-11-22 Thread Hans Verkuil
Andy, Should we perhaps change the MAINTAINERS file to point to the linux-media list instead? Regards, Hans On 11/22/2013 10:13 AM, Dan Carpenter wrote: > Btw, the MAINTAINERS file says the ivtv list is moderated but actually > it's a subscriber only list... Sucks. -- To unsubscribe f

Re: [patch] [media] cx18: check for allocation failure in cx18_read_eeprom()

2013-11-22 Thread Dan Carpenter
Btw, the MAINTAINERS file says the ivtv list is moderated but actually it's a subscriber only list... Sucks. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

[patch] [media] cx18: check for allocation failure in cx18_read_eeprom()

2013-11-21 Thread Dan Carpenter
It upsets static checkers when we don't check for allocation failure. I moved the memset() of "tv" earlier so we don't use uninitialized data on error. Fixes: 1d212cf0c2d8 ('[media] cx18: struct i2c_client is too big for stack') Signed-off-by: Dan Carpenter diff --git a/drivers/media/pci/cx18/c