Re: [patch] [media] dt3155v4l: unlock on error path

2013-04-09 Thread Hans Verkuil
On Tue April 9 2013 07:15:40 Dan Carpenter wrote: We should unlock here and do some cleanup before returning. We can't actually hit this return path with the current code, so this patch is a basically a cleanup and doesn't change how the code works. Signed-off-by: Dan Carpenter

Re: [patch] [media] dt3155v4l: unlock on error path

2013-04-09 Thread Dan Carpenter
On Tue, Apr 09, 2013 at 07:20:19AM +0200, Julia Lawall wrote: On Tue, 9 Apr 2013, Dan Carpenter wrote: We should unlock here and do some cleanup before returning. We can't actually hit this return path with the current code, so this patch is a basically a cleanup and doesn't change how

[patch] [media] dt3155v4l: unlock on error path

2013-04-08 Thread Dan Carpenter
We should unlock here and do some cleanup before returning. We can't actually hit this return path with the current code, so this patch is a basically a cleanup and doesn't change how the code works. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git

Re: [patch] [media] dt3155v4l: unlock on error path

2013-04-08 Thread Julia Lawall
On Tue, 9 Apr 2013, Dan Carpenter wrote: We should unlock here and do some cleanup before returning. We can't actually hit this return path with the current code, so this patch is a basically a cleanup and doesn't change how the code works. Why keep the return path then? If the code is