Re: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-23 Thread Marcin Slusarz
On Mon, Mar 22, 2010 at 05:04:55PM +0100, Takashi Iwai wrote: > At Mon, 22 Mar 2010 08:43:47 -0700, > Joe Perches wrote: > > > > On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: > > > card->driver is 15 characters and a NULL, the original code could > > > cause a buffer overflow. > > > >

Re: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-23 Thread Takashi Iwai
At Mon, 22 Mar 2010 18:39:09 +0300, Dan Carpenter wrote: > > card->driver is 15 characters and a NULL, the original code could > cause a buffer overflow. > > Signed-off-by: Dan Carpenter > --- > In version 2, I used a better name that Takashi Iwai suggested. Acked-by: Takashi Iwai Could you

Re: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Takashi Iwai
At Mon, 22 Mar 2010 19:54:30 +0300, Dan Carpenter wrote: > > On Mon, Mar 22, 2010 at 05:04:55PM +0100, Takashi Iwai wrote: > > At Mon, 22 Mar 2010 08:43:47 -0700, > > Joe Perches wrote: > > > > > > On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: > > > > card->driver is 15 characters and a

Re: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Dan Carpenter
On Mon, Mar 22, 2010 at 05:04:55PM +0100, Takashi Iwai wrote: > At Mon, 22 Mar 2010 08:43:47 -0700, > Joe Perches wrote: > > > > On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: > > > card->driver is 15 characters and a NULL, the original code could > > > cause a buffer overflow. > > > >

Re: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Takashi Iwai
At Mon, 22 Mar 2010 08:43:47 -0700, Joe Perches wrote: > > On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: > > card->driver is 15 characters and a NULL, the original code could > > cause a buffer overflow. > > > In version 2, I used a better name that Takashi Iwai suggested. > > Perhaps

Re: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Joe Perches
On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: > card->driver is 15 characters and a NULL, the original code could > cause a buffer overflow. > In version 2, I used a better name that Takashi Iwai suggested. Perhaps it's better to use strncpy as well. -- To unsubscribe from this list:

[patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long

2010-03-22 Thread Dan Carpenter
card->driver is 15 characters and a NULL, the original code could cause a buffer overflow. Signed-off-by: Dan Carpenter --- In version 2, I used a better name that Takashi Iwai suggested. diff --git a/drivers/media/video/cx231xx/cx231xx-audio.c b/drivers/media/video/cx231xx/cx231xx-audio.c in