On Thu, May 26, 2016 at 03:07:41PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Tuesday 24 May 2016 23:50:44 Sakari Ailus wrote:
> > On Tue, May 24, 2016 at 08:09:37PM +0300, Laurent Pinchart wrote:
> > ...
> >
> > > > + if (strcmp(entity->info.name, name) == 0)
> > >
> > >
Hi Sakari,
On Tuesday 24 May 2016 23:50:44 Sakari Ailus wrote:
> On Tue, May 24, 2016 at 08:09:37PM +0300, Laurent Pinchart wrote:
> ...
>
> > > + if (strcmp(entity->info.name, name) == 0)
> >
> > While the kernel API guarantees that entity->info.name will be NULL-
> > terminated,
Hi Laurent,
Thanks for the review!
On Tue, May 24, 2016 at 08:09:37PM +0300, Laurent Pinchart wrote:
...
> > + if (strcmp(entity->info.name, name) == 0)
>
> While the kernel API guarantees that entity->info.name will be NULL-
> terminated, wouldn't it be safer to add a safety check
Hi Sakari,
Thank you for the patch.
On Tuesday 24 May 2016 15:48:02 Sakari Ailus wrote:
> Recently it was decided that the API dealing with string operations would
> be better to just receive a nul-terminated string rather than a string the
> length of which is defined. This change was
Recently it was decided that the API dealing with string operations would
be better to just receive a nul-terminated string rather than a string the
length of which is defined. This change was implemented for
v4l2_subdev_string_to_pixelcode() and v4l2_subdev_string_to_field()
functions by patch
