Re: Correct way to do s_ctrl ioctl taking into account subdev framework?

2010-06-27 Thread Hans Verkuil
On Saturday 26 June 2010 21:04:51 Devin Heitmueller wrote: On Sat, Jun 26, 2010 at 2:51 PM, Hans Verkuil hverk...@xs4all.nl wrote: There really is no good way at the moment to handle cases like this, or at least not without a lot of work. Ok, it's good to know I'm not missing something

Re: Correct way to do s_ctrl ioctl taking into account subdev framework?

2010-06-27 Thread Mauro Carvalho Chehab
Em 27-06-2010 00:26, Devin Heitmueller escreveu: On Sat, Jun 26, 2010 at 9:34 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: would do the trick. Yet, the application is broken, as it is considering a positive return as an error. A positive code should never be considered as an error.

Correct way to do s_ctrl ioctl taking into account subdev framework?

2010-06-26 Thread Devin Heitmueller
First, a bit of background: A bug in the em28xx implementation of s_ctrl() was present where it would always return 1, even in success cases, regardless of what the subdev servicing the request said (in this case the video decoder). It was using v4l2_device_call_all(), and disregarding the return

Re: Correct way to do s_ctrl ioctl taking into account subdev framework?

2010-06-26 Thread Hans Verkuil
Hi Devin, On Saturday 26 June 2010 20:37:51 Devin Heitmueller wrote: First, a bit of background: A bug in the em28xx implementation of s_ctrl() was present where it would always return 1, even in success cases, regardless of what the subdev servicing the request said (in this case the video

Re: Correct way to do s_ctrl ioctl taking into account subdev framework?

2010-06-26 Thread Devin Heitmueller
On Sat, Jun 26, 2010 at 2:51 PM, Hans Verkuil hverk...@xs4all.nl wrote: There really is no good way at the moment to handle cases like this, or at least not without a lot of work. Ok, it's good to know I'm not missing something obvious. The plan is to have the framework merged in time for

Re: Correct way to do s_ctrl ioctl taking into account subdev framework?

2010-06-26 Thread Mauro Carvalho Chehab
Em 26-06-2010 16:04, Devin Heitmueller escreveu: On Sat, Jun 26, 2010 at 2:51 PM, Hans Verkuil hverk...@xs4all.nl wrote: There really is no good way at the moment to handle cases like this, or at least not without a lot of work. Ok, it's good to know I'm not missing something obvious. The

Re: Correct way to do s_ctrl ioctl taking into account subdev framework?

2010-06-26 Thread Devin Heitmueller
On Sat, Jun 26, 2010 at 9:34 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: would do the trick. Yet, the application is broken, as it is considering a positive return as an error. A positive code should never be considered as an error. So, we need to fix v4l2-ctl as well (ok, returning