On Sat, Jul 31, 2010 at 02:19:36AM -0700, Dmitry Torokhov wrote:
+/**
+ * struct keymap_entry - used by EVIOCGKEYCODE/EVIOCSKEYCODE ioctls
+ * @scancode: scancode represented in machine-endian form.
+ * @len: length of the scancode that resides in @scancode buffer.
+ * @index: index in the
On Sat, Jul 31, 2010 at 10:23:45AM -0300, Mauro Carvalho Chehab wrote:
Em 31-07-2010 06:19, Dmitry Torokhov escreveu:
The usefulnes of reserved data elements in the structure is
doubtful,
since we do not seem to require them being set to a particular value and
so we'll be unable to
On Sat, Jul 31, 2010 at 10:23:45AM -0300, Mauro Carvalho Chehab wrote:
Hi Dmitry,
Em 31-07-2010 06:19, Dmitry Torokhov escreveu:
Hi Mauro,
I finally got a chance to review the patches adding handling of large
scancodes to input core and there are a few things with this approach
that
On Sat, Jul 31, 2010 at 01:03:26PM +0200, Stefan Richter wrote:
Dmitry Torokhov wrote:
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -56,22 +56,35 @@ struct input_absinfo {
__s32 resolution;
};
-struct keycode_table_entry {
- __u32 keycode; /* e.g.
Em 02-08-2010 05:02, Dmitry Torokhov escreveu:
On Sat, Jul 31, 2010 at 10:23:45AM -0300, Mauro Carvalho Chehab wrote:
Hi Dmitry,
Em 31-07-2010 06:19, Dmitry Torokhov escreveu:
Hi Mauro,
I finally got a chance to review the patches adding handling of large
scancodes to input core and there
On Mon, Aug 02, 2010 at 08:35:37AM -0300, Mauro Carvalho Chehab wrote:
Em 02-08-2010 05:02, Dmitry Torokhov escreveu:
On Sat, Jul 31, 2010 at 10:23:45AM -0300, Mauro Carvalho Chehab wrote:
Hi Dmitry,
Em 31-07-2010 06:19, Dmitry Torokhov escreveu:
Hi Mauro,
I finally got a chance to
Hi Mauro,
I finally got a chance to review the patches adding handling of large
scancodes to input core and there are a few things with this approach
that I do not like.
First of all I do not think that we should be working with scancode via
a pointer as it requires additional compat handling
Hi Dmitry,
Em 31-07-2010 06:19, Dmitry Torokhov escreveu:
Hi Mauro,
I finally got a chance to review the patches adding handling of large
scancodes to input core and there are a few things with this approach
that I do not like.
Thanks for the review!
First of all I do not think that we
