Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-05 Thread Sachin Kamat
On 5 February 2013 15:03, Sylwester Nawrocki wrote: > On 02/05/2013 04:03 AM, Inki Dae wrote: > [...] >>> Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same >>> comptible string will be used for this one too. >>> And please check if exynos4212 and 4412 SoCs have same fimg-2d ip. >

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-05 Thread Sylwester Nawrocki
On 02/05/2013 04:03 AM, Inki Dae wrote: [...] >> Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same >> comptible string will be used for this one too. >> >>> And please check if exynos4212 and 4412 SoCs have same fimg-2d ip. >>> If it's different, we might need to add ip version proper

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-05 Thread Joonyoung Shim
Nawrocki; linux- >>>>> me...@vger.kernel.org; dri-de...@lists.freedesktop.org; devicetree- >>>>> disc...@lists.ozlabs.org; patc...@linaro.org >>>>> Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery >>>>> support for G2

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-04 Thread 김승우
gt; Cc: Sylwester Nawrocki; Kukjin Kim; Sylwester Nawrocki; linux- >>>>> me...@vger.kernel.org; dri-de...@lists.freedesktop.org; devicetree- >>>>> disc...@lists.ozlabs.org; patc...@linaro.org >>>>> Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-04 Thread Kyungmin Park
gt; Cc: Sylwester Nawrocki; Kukjin Kim; Sylwester Nawrocki; linux- >>>>> me...@vger.kernel.org; dri-de...@lists.freedesktop.org; devicetree- >>>>> disc...@lists.ozlabs.org; patc...@linaro.org >>>>> Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-04 Thread Inki Dae
ux-media- >>>> ow...@vger.kernel.org] On Behalf Of Sachin Kamat >>>> Sent: Friday, February 01, 2013 8:40 PM >>>> To: Inki Dae >>>> Cc: Sylwester Nawrocki; Kukjin Kim; Sylwester Nawrocki; linux- >>>> me...@vger.kernel.org; dri-de...@lists.f

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-04 Thread Sachin Kamat
Kamat >>> Sent: Friday, February 01, 2013 8:40 PM >>> To: Inki Dae >>> Cc: Sylwester Nawrocki; Kukjin Kim; Sylwester Nawrocki; linux- >>> me...@vger.kernel.org; dri-de...@lists.freedesktop.org; devicetree- >>> disc...@lists.ozlabs.org; patc...@linaro.org >

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Kukjin Kim
Kukjin Kim wrote: > Oops, I'm re-sending due to my e-mail client problem :-( > Sylwester Nawrocki wrote: > > > > On 02/01/2013 09:33 AM, Sachin Kamat wrote: > > > On 1 February 2013 06:57, Inki Dae wrote: > > >> > > >> For example, > > >> If compatible = "samsung,g2d-3.0" is added to exynos4210.

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > On 02/01/2013 09:33 AM, Sachin Kamat wrote: > > On 1 February 2013 06:57, Inki Dae wrote: > >> > >> For example, > >> If compatible = "samsung,g2d-3.0" is added to exynos4210.dtsi, it'd be > >> reasonable. But what if that compatible string is added to exynos4.dtsi?.

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Inki Dae
Sylwester Nawrocki; Kukjin Kim; Sylwester Nawrocki; linux- >> me...@vger.kernel.org; dri-de...@lists.freedesktop.org; devicetree- >> disc...@lists.ozlabs.org; patc...@linaro.org >> Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery >> support for G2D &g

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Inki Dae
er.kernel.org; dri-de...@lists.freedesktop.org; devicetree- > disc...@lists.ozlabs.org; patc...@linaro.org > Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery > support for G2D > > On 1 February 2013 17:02, Inki Dae wrote: > > > > How about usin

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Sachin Kamat
On 1 February 2013 17:02, Inki Dae wrote: > > How about using like below? > Compatible = ""samsung,exynos4x12-fimg-2d" /* for Exynos4212, > Exynos4412 */ > It looks odd to use "samsung,exynos4212-fimg-2d" saying that this ip is for > exynos4212 and exynos4412. AFAIK, compatible strings a

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Inki Dae
rnel.org; > dri-de...@lists.freedesktop.org; devicetree-disc...@lists.ozlabs.org; > patc...@linaro.org > Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery > support for G2D > > >> In any case please let me know the final preferred one so that I can >

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Sachin Kamat
>> In any case please let me know the final preferred one so that I can >> update the code send the revised patches. > > The version with SoC name embedded in it seems most reliable and correct > to me. > > compatible = "samsung,exynos3110-fimg-2d" /* for Exynos3110 (S5PC110, > S5PV210), >

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Sylwester Nawrocki
On 02/01/2013 09:33 AM, Sachin Kamat wrote: > On 1 February 2013 06:57, Inki Dae wrote: >> >> For example, >> If compatible = "samsung,g2d-3.0" is added to exynos4210.dtsi, it'd be >> reasonable. But what if that compatible string is added to exynos4.dtsi?. >> This case isn't considered for exynos

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Sachin Kamat
On 1 February 2013 06:57, Inki Dae wrote: > > For example, > If compatible = "samsung,g2d-3.0" is added to exynos4210.dtsi, it'd be > reasonable. But what if that compatible string is added to exynos4.dtsi?. > This case isn't considered for exynos4412 SoC with v4.1. In case of Exynos4 series the

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-31 Thread Stephen Warren
ster Nawrocki'; 'Inki Dae' >> Cc: 'Sachin Kamat'; linux-media@vger.kernel.org; dri- >> de...@lists.freedesktop.org; devicetree-disc...@lists.ozlabs.org; >> patc...@linaro.org; s.nawro...@samsung.com >> Subject: RE: [PATCH 2/2] drm/exynos: Add devi

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-31 Thread Inki Dae
at'; linux-media@vger.kernel.org; dri- > de...@lists.freedesktop.org; devicetree-disc...@lists.ozlabs.org; > patc...@linaro.org; s.nawro...@samsung.com > Subject: RE: [PATCH 2/2] drm/exynos: Add device tree based discovery > support for G2D > > Sylwester Nawrocki wrote: > >

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-31 Thread Kukjin Kim
> >> To: Inki Dae > >> Cc: Sachin Kamat; linux-media@vger.kernel.org; dri- > >> de...@lists.freedesktop.org; devicetree-disc...@lists.ozlabs.org; > >> patc...@linaro.org; s.nawro...@samsung.com > >> Subject: Re: [PATCH 2/2] drm/exynos: Add device tree b

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-31 Thread Sylwester Nawrocki
...@lists.ozlabs.org; patc...@linaro.org; s.nawro...@samsung.com Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D On 01/30/2013 09:50 AM, Inki Dae wrote: +static const struct of_device_id exynos_g2d_match[] = { + { .compatible = "samsung,g2d-v41" },

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-30 Thread Inki Dae
t; patc...@linaro.org; s.nawro...@samsung.com > Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery > support for G2D > > On 01/30/2013 09:50 AM, Inki Dae wrote: > >> +static const struct of_device_id exynos_g2d_match[] = { > >> + { .compatible

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-30 Thread Sylwester Nawrocki
On 01/30/2013 09:50 AM, Inki Dae wrote: +static const struct of_device_id exynos_g2d_match[] = { + { .compatible = "samsung,g2d-v41" }, not only Exynos5 and also Exyno4 has the g2d gpu and drm-based g2d driver shoud support for all Exynos SoCs. How about using "samsung,exynos5-g2d" instea

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-30 Thread Inki Dae
2013/1/25 Sachin Kamat : > From: Ajay Kumar > > This patch adds device tree match table for Exynos G2D controller. > > Signed-off-by: Ajay Kumar > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) >