Hi Tomasz,
Please check my comments below.
>Hi Ping-chung,
>On Mon, Jul 30, 2018 at 6:19 PM Ping-chung Chen
>wrote:
>
> From: "Chen, Ping-chung"
>
> Add a V4L2 sub-device driver for the Sony IMX208 image sensor.
> This is a camera sensor using the I2C bus for control and the
> CSI-2 bus for
On Tue, Jul 31, 2018 at 12:54 PM Chen, Ping-chung
wrote:
>
> Hi Tomasz,
>
> >-Original Message-
> > +/* Get bayer order based on flip setting. */ static __u32
> > +imx208_get_format_code(struct imx208 *imx208)
>
> >Why not just "u32"?
>
> Its return value will be assigned to the variable
Hi Tomasz,
>-Original Message-
> +/* Get bayer order based on flip setting. */ static __u32
> +imx208_get_format_code(struct imx208 *imx208)
>Why not just "u32"?
Its return value will be assigned to the variable code which belongs to the
structure
v4l2_subdev_mbus_code_enum, and the
@vger.kernel.org; Yeh, Andy ; Lai, Jim
; tf...@google.com; grund...@chromium.org; Mani, Rajmohan
Subject: Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver
Hi Ping-chung,
On Mon, Jul 30, 2018 at 05:26:39PM +0800, Ping-chung Chen wrote:
> From: "Chen, Ping-chung"
>
> Ad
On Mon, Jul 30, 2018 at 8:39 PM Sakari Ailus
wrote:
>
> Hi Tomasz,
>
> On Mon, Jul 30, 2018 at 07:19:56PM +0900, Tomasz Figa wrote:
> ...
> > > +static int imx208_set_ctrl(struct v4l2_ctrl *ctrl)
> > > +{
> > > + struct imx208 *imx208 =
> > > + container_of(ctrl->handler,
Hi Tomasz,
On Mon, Jul 30, 2018 at 07:19:56PM +0900, Tomasz Figa wrote:
...
> > +static int imx208_set_ctrl(struct v4l2_ctrl *ctrl)
> > +{
> > + struct imx208 *imx208 =
> > + container_of(ctrl->handler, struct imx208, ctrl_handler);
> > + struct i2c_client *client =
Hi Ping-chung,
On Mon, Jul 30, 2018 at 05:26:39PM +0800, Ping-chung Chen wrote:
> From: "Chen, Ping-chung"
>
> Add a V4L2 sub-device driver for the Sony IMX208 image sensor.
> This is a camera sensor using the I2C bus for control and the
> CSI-2 bus for data.
>
> Signed-off-by: Ping-Chung Chen
Hi Ping-chung,
On Mon, Jul 30, 2018 at 6:19 PM Ping-chung Chen
wrote:
>
> From: "Chen, Ping-chung"
>
> Add a V4L2 sub-device driver for the Sony IMX208 image sensor.
> This is a camera sensor using the I2C bus for control and the
> CSI-2 bus for data.
>
Please see my comments inline.
[snip]
>
