Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-16 Thread kbuild test robot
Hi Jason, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc5 next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-16 Thread Yeh, Andy
riginal Message- From: lkp Sent: Friday, March 16, 2018 10:14 PM To: Yeh, Andy Cc: kbuild-...@01.org; linux-media@vger.kernel.org; tf...@chromium.org; sakari.ai...@linux.intel.com; Yeh, Andy ; Chen, JasonX Z ; Chiang, AlanX ; Lai, Jim Subject: Re: [PATCH v8] media: imx258: Add imx258 camera se

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-16 Thread kbuild test robot
Hi Jason, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc5 next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-15 Thread Yeh, Andy
] media: imx258: Add imx258 camera sensor driver Hi Andy, Thanks for the update. Two minor comments below. On Thu, Mar 15, 2018 at 12:24:19AM +0800, Andy Yeh wrote: ... > +static int imx258_set_ctrl(struct v4l2_ctrl *ctrl) { > + struct imx258 *imx258 = > + container_of(ctrl

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-15 Thread Sakari Ailus
Hi Andy, On Wed, Mar 14, 2018 at 04:29:52PM +, Yeh, Andy wrote: > Still wrong line break... > Please check the list instead. Thanks. > https://patchwork.linuxtv.org/patch/47936/ The patch you sent using git send-email seems fine; I bet it's your e-mail client that does the rewrapping. -- Re

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-14 Thread Yeh, Andy
: imx258: Add imx258 camera sensor driver Hi Andy, Thanks for the update. Two minor comments below. On Thu, Mar 15, 2018 at 12:24:19AM +0800, Andy Yeh wrote: ... > +static int imx258_set_ctrl(struct v4l2_ctrl *ctrl) { > + struct imx258 *imx258 = > + container_of(ctrl

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-14 Thread Sakari Ailus
Hi Andy, Thanks for the update. Two minor comments below. On Thu, Mar 15, 2018 at 12:24:19AM +0800, Andy Yeh wrote: ... > +static int imx258_set_ctrl(struct v4l2_ctrl *ctrl) > +{ > + struct imx258 *imx258 = > + container_of(ctrl->handler, struct imx258, ctrl_handler); > + stru

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-14 Thread Yeh, Andy
Still wrong line break... Please check the list instead. Thanks. https://patchwork.linuxtv.org/patch/47936/ Regards, Andy -Original Message- From: Yeh, Andy Sent: Thursday, March 15, 2018 12:24 AM To: linux-media@vger.kernel.org; tf...@chromium.org Cc: sakari.ai...@linux.intel.com; Yeh,

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-09 Thread Yeh, Andy
ay, March 9, 2018 6:20 PM > To: Sakari Ailus > Cc: Yeh, Andy ; Linux Media Mailing List > ; Chen, JasonX Z > ; Chiang, AlanX > Subject: Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver > > Hi Andy, Sakari, > > On Fri, Mar 9, 2018 at 5:54 PM, Sakari Ailus

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-09 Thread Tomasz Figa
gt; To: Sakari Ailus > Cc: Yeh, Andy ; Linux Media Mailing List > ; Chen, JasonX Z ; > Chiang, AlanX > Subject: Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver > > Hi Andy, Sakari, > > On Fri, Mar 9, 2018 at 5:54 PM, Sakari Ailus > wrote: >> Hi And

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-09 Thread Yeh, Andy
: Yeh, Andy ; Linux Media Mailing List ; Chen, JasonX Z ; Chiang, AlanX Subject: Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver Hi Andy, Sakari, On Fri, Mar 9, 2018 at 5:54 PM, Sakari Ailus wrote: > Hi Andy, > > Thanks for the update. Please see my comments below. &

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-09 Thread Tomasz Figa
Hi Andy, Sakari, On Fri, Mar 9, 2018 at 5:54 PM, Sakari Ailus wrote: > Hi Andy, > > Thanks for the update. Please see my comments below. > > On Fri, Mar 09, 2018 at 12:15:54AM +0800, Andy Yeh wrote: >> Add a V4L2 sub-device driver for the Sony IMX258 image sensor. >> This is a camera sensor using

Re: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-09 Thread Sakari Ailus
Hi Andy, Thanks for the update. Please see my comments below. On Fri, Mar 09, 2018 at 12:15:54AM +0800, Andy Yeh wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Jason