Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-04-08 Thread Laurent Pinchart
Hi Sylwester, On Thursday 07 April 2011 00:04:45 Sylwester Nawrocki wrote: On 04/06/2011 10:05 PM, Sylwester Nawrocki wrote: On 03/07/2011 12:20 AM, Pawel Osciak wrote: On Tue, Mar 1, 2011 at 02:54, Laurent Pinchart wrote: On Monday 28 February 2011 16:44:38 Pawel Osciak wrote: Hi

RE: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-04-08 Thread Marek Szyprowski
Hello, On Friday, April 08, 2011 2:53 PM Laurent Pinchart wrote: ... As buf_queue callback is called by vb2 only after start_streaming, for a camera snapshot capture I needed to start a pipeline only from the buf_queue handler level, i.e. subdev's video s_stream op was called from

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-04-08 Thread Laurent Pinchart
Hi Marek, On Friday 08 April 2011 15:09:02 Marek Szyprowski wrote: On Friday, April 08, 2011 2:53 PM Laurent Pinchart wrote: [snip] buf_queue is called with a spinlock help, so you can't perform I2C communication there. In videobuf2 buf_queue() IS NOT called with any spinlock held.

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-04-08 Thread Sylwester Nawrocki
Hi Laurent! On 04/08/2011 02:53 PM, Laurent Pinchart wrote: Hi Sylwester, On Thursday 07 April 2011 00:04:45 Sylwester Nawrocki wrote: On 04/06/2011 10:05 PM, Sylwester Nawrocki wrote: On 03/07/2011 12:20 AM, Pawel Osciak wrote: On Tue, Mar 1, 2011 at 02:54, Laurent Pinchart wrote: On

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-04-06 Thread Sylwester Nawrocki
On 04/06/2011 10:05 PM, Sylwester Nawrocki wrote: Hi Pawel, On 03/07/2011 12:20 AM, Pawel Osciak wrote: Hi Laurent, On Tue, Mar 1, 2011 at 02:54, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Pawel, On Monday 28 February 2011 16:44:38 Pawel Osciak wrote: Hi Laurent, A

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-03-08 Thread Laurent Pinchart
Hi Pawel, On Monday 07 March 2011 00:20:36 Pawel Osciak wrote: On Tue, Mar 1, 2011 at 02:54, Laurent Pinchart wrote: On Monday 28 February 2011 16:44:38 Pawel Osciak wrote: Hi Laurent, A few questions from me below. I feel we need to talk about this change a bit more, it introduces some

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-03-06 Thread Pawel Osciak
Hi Laurent, On Tue, Mar 1, 2011 at 02:54, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Pawel, On Monday 28 February 2011 16:44:38 Pawel Osciak wrote: Hi Laurent, A few questions from me below. I feel we need to talk about this change a bit more, it introduces some recovery

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-03-06 Thread Andy Walls
On Sun, 2011-03-06 at 15:20 -0800, Pawel Osciak wrote: Hi Laurent, On Tue, Mar 1, 2011 at 02:54, Laurent Pinchart I think a disconnection is pretty fatal. If the user unplugs the webcam, there's not much that can be done anymore. Userspace needs to be woken up with all buffers

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-03-01 Thread Laurent Pinchart
Hi Pawel, On Monday 28 February 2011 16:44:38 Pawel Osciak wrote: Hi Laurent, A few questions from me below. I feel we need to talk about this change a bit more, it introduces some recovery and consistency problems, unless I'm missing something. On Sun, Feb 27, 2011 at 10:12, Laurent

RE: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-02-28 Thread Marek Szyprowski
Hello, On Sunday, February 27, 2011 7:13 PM Laurent Pinchart wrote: videobuf2 expects drivers to check buffer in the buf_prepare operation and to return success only if the buffer can queued without any issue. For hot-pluggable devices, disconnection events need to be handled at buf_queue

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

2011-02-28 Thread Pawel Osciak
Hi Laurent, A few questions from me below. I feel we need to talk about this change a bit more, it introduces some recovery and consistency problems, unless I'm missing something. On Sun, Feb 27, 2011 at 10:12, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: videobuf2 expects drivers