On 10/10/2018 04:32 PM, Sakari Ailus wrote:
> While there are issues related to object lifetime management, unregister
> the media device first, followed immediately by other device nodes when
> the driver is being unbound. Only then the resources needed by the driver
> may be released. This is
Hi!
> Add support for exponential bases, prefixes as well as units for V4L2
> controls. This makes it possible to convey information on the relation
> between the control value and the hardware feature being controlled.
>
> Signed-off-by: Sakari Ailus
Sounds good.
> +/* V4L2 control
On Thu, Oct 11, 2018 at 05:16:30PM +0800, Bing Bu Cao wrote:
> Tested-by: Bingbu Cao
> Reviewed-by: Bingbu Cao
Thanks!!
--
Sakari Ailus
sakari.ai...@linux.intel.com
On Sat, Oct 13, 2018 at 11:02 AM Akinobu Mita wrote:
>
> The video device release() callback for video-i2c driver frees the whole
> struct video_i2c_data. If there is no user left for the video device
> when video_unregister_device() is called, the release callback is executed.
>
> However, in
On 05.10.2018 17:30, Mauro Carvalho Chehab wrote:
> Em Fri, 5 Oct 2018 16:34:28 +0200
> Oliver Freyermuth escreveu:
>
>> Dear Mauro,
>>
>> thanks! Just to clarify, the issue I described in
>> https://bugzilla.kernel.org/show_bug.cgi?id=199323
>> was on an Intel x86_64 system, with an onboard
On 09/18/2018 02:34 AM, Philipp Zabel wrote:
+/*
+ * Tile left edges are required to be aligned to multiples of 8 bytes
+ * by the IDMAC.
+ */
+static inline u32 tile_left_align(const struct ipu_image_pixfmt *fmt)
+{
+ return fmt->planar ? 8 * fmt->uv_width_dec : 64 / fmt->bpp;
+}
ernal image converter implementation.
- Remove the source and destination buffers on error in device_run().
Otherwise the conversion is re-attempted apparently over and over
again (with WARN() backtraces).
- Allow subscribing to control changes.
- Fix seam position selection for more corner
Hi,
Le mercredi 19 septembre 2018 à 13:28 +0900, Tomasz Figa a écrit :
> On Thu, Sep 13, 2018 at 9:15 PM Paul Kocialkowski wrote:
> > Hi,
> >
> > On Wed, 2018-09-05 at 19:00 -0300, Ezequiel Garcia wrote:
> > > From: Shunqian Zheng
> > >
> > > Add V4L2_CID_JPEG_QUANTIZATION compound control to
On 10/11/2018 08:54 PM, Dafna Hirschfeld wrote:
> Replace hardcoded function names with `__func__`
> in debug prints.
>
> Signed-off-by: Dafna Hirschfeld
Acked-by: Hans Verkuil
Thanks!
Hans
> ---
> .../staging/media/davinci_vpfe/dm365_ipipe.c | 6 +-
>
On Fri, Oct 12, 2018 at 4:58 PM Sakari Ailus
wrote:
>
> Hi Tomasz,
>
> On Fri, Oct 12, 2018 at 01:51:10PM +0900, Tomasz Figa wrote:
> > Hi Sakari,
> >
> > On Wed, Sep 26, 2018 at 11:38 AM wrote:
> > >
> > > From: Bingbu Cao
> > >
> > > Add a v4l2 sub-device driver for the Sony imx319 image
Hi Tomasz,
On Fri, Oct 12, 2018 at 01:51:10PM +0900, Tomasz Figa wrote:
> Hi Sakari,
>
> On Wed, Sep 26, 2018 at 11:38 AM wrote:
> >
> > From: Bingbu Cao
> >
> > Add a v4l2 sub-device driver for the Sony imx319 image sensor.
> > This is a camera sensor using the i2c bus for control and the
> >
Hi Sakari,
On Wed, Sep 26, 2018 at 11:38 AM wrote:
>
> From: Bingbu Cao
>
> Add a v4l2 sub-device driver for the Sony imx319 image sensor.
> This is a camera sensor using the i2c bus for control and the
> csi-2 bus for data.
>
> This driver supports following features:
> - manual exposure and
On Mon, Oct 08, 2018 at 09:46:01PM -0700, Joel Fernandes wrote:
> On Fri, Apr 06, 2018 at 10:23:04AM -0400, Mauro Carvalho Chehab wrote:
> > As warned:
> > drivers/staging/media/davinci_vpfe/dm365_ipipe.c:1834 vpfe_ipipe_init()
> > error: we previously assumed 'res' could be null (see line
On 10/11/2018 05:33 PM, Kieran Bingham wrote:
> Hi Rajmohan
>
> Thank you for the patch,
>
> On 10/10/18 00:42, Rajmohan Mani wrote:
>> Removed redundant CIO2_IMAGE_MAX_* definitions
>>
>> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")
>>
>> Signed-off-by: Rajmohan
Hi Rajmohan
Thank you for the patch,
On 10/10/18 00:42, Rajmohan Mani wrote:
> Removed redundant CIO2_IMAGE_MAX_* definitions
>
> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")
>
> Signed-off-by: Rajmohan Mani
Reviewed-by: Kieran Bingham
Looks like this
Tested-by: Bingbu Cao
Reviewed-by: Bingbu Cao
On 10/10/2018 04:32 PM, Sakari Ailus wrote:
> The ipu3-cio2 driver has a function to tear down video devices as well as
> the associated video buffer queues. Use it.
>
> Signed-off-by: Sakari Ailus
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.c
Tested-by: Bingbu Cao
Reviewed-by: Bingbu Cao
On 10/10/2018 04:32 PM, Sakari Ailus wrote:
> While there are issues related to object lifetime management, unregister
> the media device first, followed immediately by other device nodes when
> the driver is being unbound. Only then the resources
On Thu, Oct 11, 2018 at 5:26 PM Stanimir Varbanov
wrote:
>
> Hi Alex,
>
> On 10/11/2018 09:50 AM, Alexandre Courbot wrote:
> > Please ignore this patch - I did not notice that a similar one has
> > been sent before.
>
> The difference is that you made it for decoder as well. Do you need
> userptr
On Mon, 2018-10-08 at 13:53 +0200, Hans Verkuil wrote:
> Hi all,
>
> I would like to meet up somewhere during the ELCE to discuss userspace support
> for stateless (and perhaps stateful as well?) codecs.
>
> It is also planned as a topic during the summit, but I would prefer to prepare
> for
Hi Alex,
On 10/11/2018 09:50 AM, Alexandre Courbot wrote:
> Please ignore this patch - I did not notice that a similar one has
> been sent before.
The difference is that you made it for decoder as well. Do you need
userptr for decoder?
--
regards,
Stan
On Tue, Oct 9, 2018 at 4:52 PM Malathi Gottam wrote:
>
> Add USERPTR to queue access methods by adding this
> support to io_modes on both the planes.
>
> Signed-off-by: Malathi Gottam
Tested-by: Alexandre Courbot
Please ignore this patch - I did not notice that a similar one has
been sent before. >_<
On Thu, Oct 11, 2018 at 3:46 PM Alexandre Courbot wrote:
>
> The venus codec can work just fine with USERPTR buffers. Enable this
> possibility.
>
> Signed-off-by: Alexandre Courbot
> ---
>
On Wed, Oct 10, 2018 at 03:45:35PM +0200, Hans Verkuil wrote:
> On 10/10/18 14:09, ektor5 wrote:
> > Hi Hans,
> >
> > On Sat, Oct 06, 2018 at 11:54:38AM +0200, Hans Verkuil wrote:
> >> Hi Ettore,
> >>
> >> On 10/05/2018 07:33 PM, ektor5 wrote:
> >>> This series of patches aims to add CEC
On 10/10/18 14:09, ektor5 wrote:
> Hi Hans,
>
> On Sat, Oct 06, 2018 at 11:54:38AM +0200, Hans Verkuil wrote:
>> Hi Ettore,
>>
>> On 10/05/2018 07:33 PM, ektor5 wrote:
>>> This series of patches aims to add CEC functionalities to SECO
>>> devices, in particular UDOO X86.
>>>
>>> The communication
Hi Jacopo,
On Wednesday, 10 October 2018 13:58:04 EEST jacopo mondi wrote:
> Hi Sam,
>thanks for the patch, I see the same issue you reported, but I
> think this patch can be improved.
>
> (expanding the Cc list to all people involved in recent ov5640
> developemts, not just for this patch,
Hi Hans,
On Sat, Oct 06, 2018 at 11:54:38AM +0200, Hans Verkuil wrote:
> Hi Ettore,
>
> On 10/05/2018 07:33 PM, ektor5 wrote:
> > This series of patches aims to add CEC functionalities to SECO
> > devices, in particular UDOO X86.
> >
> > The communication is achieved via Braswell SMBus
Hi Sam,
thanks for the patch, I see the same issue you reported, but I
think this patch can be improved.
(expanding the Cc list to all people involved in recent ov5640
developemts, not just for this patch, but for the whole series to look
at. Copying names from another series cover letter,
Hi Hans,
Thank you for the patch,
On 10/10/18 08:03, Hans Verkuil wrote:
> Lower the minimum height to 360 to be consistent with the webcam input of
> vivid.
>
> The 480 was rather arbitrary but it made it harder to use vivid as a source
> for
> encoding since the default resolution when you
Hi Sam,
On Mon, Oct 08, 2018 at 11:48:00PM -0700, Sam Bobrowicz wrote:
> Light frequency was not properly returned when in auto
> mode and the detected frequency was 60Hz. Fix this.
>
> Signed-off-by: Sam Bobrowicz
This is indeed a bugfix
Acked-by: Jacopo Mondi
Thanks
j
> ---
>
Hi Sam,
thanks for the patch.
On Mon, Oct 08, 2018 at 11:48:01PM -0700, Sam Bobrowicz wrote:
> Add a check to g_volatile_ctrl to prevent trying to read
> registers when the sensor is not powered.
>
> Signed-off-by: Sam Bobrowicz
I've been carrying a similar patch in my tree. I found it is
On 10/08/2018 01:53 PM, Hans Verkuil wrote:
> Hi all,
>
> I would like to meet up somewhere during the ELCE to discuss userspace support
> for stateless (and perhaps stateful as well?) codecs.
>
> It is also planned as a topic during the summit, but I would prefer to prepare
> for that in
Hi Hans,
On Mon, Oct 8, 2018 at 8:53 PM Hans Verkuil wrote:
>
> Hi all,
>
> I would like to meet up somewhere during the ELCE to discuss userspace support
> for stateless (and perhaps stateful as well?) codecs.
>
> It is also planned as a topic during the summit, but I would prefer to prepare
>
Le lundi 08 octobre 2018 à 13:53 +0200, Hans Verkuil a écrit :
> Hi all,
>
> I would like to meet up somewhere during the ELCE to discuss userspace support
> for stateless (and perhaps stateful as well?) codecs.
>
> It is also planned as a topic during the summit, but I would prefer to prepare
>
Hi Hans,
On Monday, 8 October 2018 14:53:29 EEST Hans Verkuil wrote:
> Hi all,
>
> I would like to meet up somewhere during the ELCE to discuss userspace
> support for stateless (and perhaps stateful as well?) codecs.
>
> It is also planned as a topic during the summit, but I would prefer to
>
Hi Sakari,
Thank you for the patch.
On Tuesday, 9 October 2018 15:03:16 EEST Sakari Ailus wrote:
> While there are issues related to object lifetime management, unregister the
> media device first when the driver is being unbound. This is slightly
> safer.
>
> Signed-off-by: Sakari Ailus
On Tue, 09 Oct 2018 at 07:29, Mauro Carvalho Chehab wrote:
> Em Mon, 8 Oct 2018 13:53:29 +0200
> Hans Verkuil escreveu:
>
> > Hi all,
> >
> > I would like to meet up somewhere during the ELCE to discuss userspace
> > support
> > for stateless (and perhaps stateful as well?) codecs.
> >
> > It
On Mon, 2018-10-08 at 13:53 +0200, Hans Verkuil wrote:
> Hi all,
>
> I would like to meet up somewhere during the ELCE to discuss userspace support
> for stateless (and perhaps stateful as well?) codecs.
>
> It is also planned as a topic during the summit, but I would prefer to prepare
> for
On Tue, Oct 09, 2018 at 01:32:57PM +0200, Hans Verkuil wrote:
> On 10/09/18 13:31, Sakari Ailus wrote:
> > The format fields in struct v4l2_format were otherwise reported but the
> > meta field was missing. Document it.
> >
> > Reported-by: Hans Verkuil
> > Signed-off-by: Sakari Ailus
>
>
On 10/09/18 13:31, Sakari Ailus wrote:
> The format fields in struct v4l2_format were otherwise reported but the
> meta field was missing. Document it.
>
> Reported-by: Hans Verkuil
> Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Thanks!
Hans
> ---
>
Em Mon, 8 Oct 2018 13:53:29 +0200
Hans Verkuil escreveu:
> Hi all,
>
> I would like to meet up somewhere during the ELCE to discuss userspace support
> for stateless (and perhaps stateful as well?) codecs.
>
> It is also planned as a topic during the summit, but I would prefer to prepare
> for
Hi!
Thanks for setting this up
On Mon, Oct 08, 2018 at 01:53:29PM +0200, Hans Verkuil wrote:
> Hi all,
>
> I would like to meet up somewhere during the ELCE to discuss userspace support
> for stateless (and perhaps stateful as well?) codecs.
>
> It is also planned as a topic during the summit,
On Fri, Apr 06, 2018 at 10:23:04AM -0400, Mauro Carvalho Chehab wrote:
> As warned:
> drivers/staging/media/davinci_vpfe/dm365_ipipe.c:1834 vpfe_ipipe_init()
> error: we previously assumed 'res' could be null (see line 1797)
>
> There's something wrong at vpfe_ipipe_init():
>
> 1) it
On 10/08/2018 09:08 PM, Hans Verkuil wrote:
> When the OSD is on (i.e. vivid displays text on top of the test pattern), and
> you enable hflip, then the driver crashes.
>
> The cause turned out to be a division of a negative number by an unsigned
> value.
> You expect that -8 / 2 would be -4,
Hi Benjamin,
Thanks for your driver, I have some comments below.
On Thu, Oct 04, 2018 at 01:52:54PM +0200, Benjamin Valentin wrote:
> The Xbox DVD Movie Playback Kit is a USB dongle with an IR remote for the
> Original Xbox.
>
> Historically it has been supported by the out-of-tree lirc_xbox
Hi Hans
On 08/10/18 12:53, Hans Verkuil wrote:
> Hi all,
>
> I would like to meet up somewhere during the ELCE to discuss userspace support
> for stateless (and perhaps stateful as well?) codecs.
>
> It is also planned as a topic during the summit, but I would prefer to prepare
> for that in
On 10/08/2018 09:08 PM, Hans Verkuil wrote:
> When the OSD is on (i.e. vivid displays text on top of the test pattern), and
> you enable hflip, then the driver crashes.
>
> The cause turned out to be a division of a negative number by an unsigned
> value.
> You expect that -8 / 2 would be -4,
..@chromium.org; mche...@kernel.org;
> hans.verk...@cisco.com; laurent.pinch...@ideasonboard.com; Zheng, Jian Xu
> ; Hu, Jerry W ; Li, Chao C
> ; Qiu, Tian Shu
> Subject: Re: [PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI
>
> Hi Raj,
>
> On Wed, Oct 03, 2
Hi Mauro,
On Mon, Oct 08, 2018 at 12:57:22PM -0300, Mauro Carvalho Chehab wrote:
> Em Sun, 7 Oct 2018 16:05:57 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > This last pull for 4.20 contains dw9714 and dw9807 lens driver probe error
> > handling fixes and the Sony imx214 sensor driver.
Em Sun, 7 Oct 2018 16:05:57 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> This last pull for 4.20 contains dw9714 and dw9807 lens driver probe error
> handling fixes and the Sony imx214 sensor driver. In other words, patches
> that have roughly nil changes of breaking something.
>
> Compile
Hi Hans,
On Fri, Oct 05, 2018 at 09:49:00AM +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This patch series converts the last remaining drivers that use g/s_crop and
> cropcap to g/s_selection.
>
> The first two patches do some minor code cleanup.
>
> The third patch adds a new
2018年10月8日(月) 20:21 Hans Verkuil :
>
> On 10/05/2018 04:59 PM, Akinobu Mita wrote:
> > 2018年10月5日(金) 18:36 Sakari Ailus :
> >>
> >> Hi Hans,
> >>
> >> On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> >>> On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> The video_i2c_data is
On Mon, Oct 08, 2018 at 03:29:03PM +0200, Hans Verkuil wrote:
> On 10/08/2018 03:07 PM, Greg KH wrote:
> > On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote:
> >> Replace calls to `printk` with the appropriate `pr_*`
> >> macro.
> >>
> >> Signed-off-by: Dafna Hirschfeld
> >> ---
>
On 10/08/2018 03:07 PM, Greg KH wrote:
> On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote:
>> Replace calls to `printk` with the appropriate `pr_*`
>> macro.
>>
>> Signed-off-by: Dafna Hirschfeld
>> ---
>> drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +-
>>
On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote:
> Replace calls to `printk` with the appropriate `pr_*`
> macro.
>
> Signed-off-by: Dafna Hirschfeld
> ---
> drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +-
> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 +++---
>
On 10/05/2018 04:59 PM, Akinobu Mita wrote:
> 2018年10月5日(金) 18:36 Sakari Ailus :
>>
>> Hi Hans,
>>
>> On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
>>> On 09/23/2018 06:34 PM, Akinobu Mita wrote:
The video_i2c_data is allocated by kzalloc and released by the video
On 10/04/2018 05:03 PM, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab
>
> Add a glossary of terms used within the media userspace API
> documentation, as several concepts are complex enough to cause
> misunderstandings.
>
> Signed-off-by: Mauro Carvalho Chehab
With the
On Sat, 2018-10-06 at 07:36 +, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing
> ---
> drivers/media/platform/imx-pxp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/imx-pxp.c
> b/drivers/media/platform/imx-pxp.c
> index
Hi Dafna,
Thanks for you patch.
On 10/6/18 4:21 PM, Dafna Hirschfeld wrote:
> Replace calls to `printk` with the appropriate `pr_*`
> macro.
>
> Signed-off-by: Dafna Hirschfeld
> ---
> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8
> drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c |
On 10/07/2018 10:39 AM, Dafna Hirschfeld wrote:
> Hi,
> As part of applying to the outreachy program,
> I compiled the code in https://gitlab.collabora.com/koike/v4l2-codec.git
> I get errors running it.
> When I install vicodec.ko I see in the kernel log:
>
> [10752.727509] vicodec vicodec.0:
On 10/07/2018 01:03 AM, Sasha Levin wrote:
> On Sat, Oct 06, 2018 at 10:21:38PM +0300, Dafna Hirschfeld wrote:
>> Replace calls to `printk` with the appropriate `pr_*`
>> macro.
>
> Hi Dafna,
>
> I'd encourage you to look into the dev_ family of print functions (such
> as dev_info() ). They can
On Sat, Oct 06, 2018 at 10:21:38PM +0300, Dafna Hirschfeld wrote:
Replace calls to `printk` with the appropriate `pr_*`
macro.
Hi Dafna,
I'd encourage you to look into the dev_ family of print functions (such
as dev_info() ). They can avoid having to repeat the driver name in
every print
Hi Ettore,
On 10/05/2018 07:33 PM, ektor5 wrote:
> This series of patches aims to add CEC functionalities to SECO
> devices, in particular UDOO X86.
>
> The communication is achieved via Braswell SMBus (i2c-i801) to the
> onboard STM32 microcontroller that handles the CEC signals. The driver
>
Em Thu, 04 Oct 2018 23:06:02 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Thursday, 4 October 2018 21:45:05 EEST Mauro Carvalho Chehab wrote:
> > Em Tue, 2 Oct 2018 08:35:47 +0200 Ludovic Desroches escreveu:
> > > On Mon, Oct 01, 2018 at 01:51:01PM -0300, Mauro Carvalho Chehab wrote:
On Fri, 2018-10-05 at 13:49 -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 05 Oct 2018 12:37:43 -0300
> Ezequiel Garcia escreveu:
>
> > On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote:
> > > Em Thu, 04 Oct 2018 20:39:31 -0300
> > > Ezequiel Garcia escreveu:
> > >
> > > > On
Em Fri, 05 Oct 2018 12:37:43 -0300
Ezequiel Garcia escreveu:
> On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote:
> > Em Thu, 04 Oct 2018 20:39:31 -0300
> > Ezequiel Garcia escreveu:
> >
> > > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote:
> > > > On Fri, 2018-09-28
On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 04 Oct 2018 20:39:31 -0300
> Ezequiel Garcia escreveu:
>
> > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote:
> > > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote:
> > > > On 09/17/2018 07:30 PM, Ezequiel
On Mon, Sep 24, 2018 at 01:34:46AM +0900, Akinobu Mita wrote:
> This patchset adds support for changing frame interval and runtime PM for
> video-i2c driver. This also adds an helper macro to v4l2 common
> internal API that is used to to find a suitable frame interval.
>
> There are a couple of
Em Fri, 5 Oct 2018 16:34:28 +0200
Oliver Freyermuth escreveu:
> Dear Mauro,
>
> thanks! Just to clarify, the issue I described in
> https://bugzilla.kernel.org/show_bug.cgi?id=199323
> was on an Intel x86_64 system, with an onboard USB Controller handled by the
> standard xhci driver,
> so
Hi Mita-san,
On Fri, Oct 05, 2018 at 11:59:20PM +0900, Akinobu Mita wrote:
> 2018年10月5日(金) 18:36 Sakari Ailus :
> >
> > Hi Hans,
> >
> > On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> > > On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> > > > The video_i2c_data is allocated by
2018年10月5日(金) 18:36 Sakari Ailus :
>
> Hi Hans,
>
> On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> > On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> > > The video_i2c_data is allocated by kzalloc and released by the video
> > > device's release callback. The release callback is
ormal ones. Anyway, as this patch
> is mostly a cleanup, better to revert it.
>
> This reverts commit 7d95fb746c4eece67308f1642a666ea1ebdbd2cc.
>
> Cc: sta...@vger.kernel.org # For Kernel 4.18
> Signed-off-by: Mauro Carvalho Chehab
> ---
>
> Re-sending it with the right message I
Hi,
On 05-10-18 13:55, Mauro Carvalho Chehab wrote:
Em Mon, 1 Oct 2018 18:19:21 +0100
Dave Stevenson escreveu:
Hi All,
On Mon, 1 Oct 2018 at 17:32, Ezequiel Garcia wrote:
Hi Hans,
Thanks for looking into. I remember MJPEG vs. JPEG being a source
of confusion for me a few years ago, so
Em Fri, 05 Oct 2018 08:53:14 -0300
Ezequiel Garcia escreveu:
> On Fri, 2018-10-05 at 08:09 -0300, Mauro Carvalho Chehab wrote:
> > Em Thu, 4 Oct 2018 21:12:24 -0300
> > Ezequiel Garcia escreveu:
> >
> > > From: Shunqian Zheng
> > >
> > > Add V4L2_PIX_FMT_JPEG_RAW format that does not
Em Thu, 04 Oct 2018 20:39:31 -0300
Ezequiel Garcia escreveu:
> On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote:
> > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote:
> > > On 09/17/2018 07:30 PM, Ezequiel Garcia wrote:
> > > > This series adds support for JPEG encoding via the
Am Freitag, 5. Oktober 2018, 02:12:22 CEST schrieb Ezequiel Garcia:
> Add the Video Processing Unit node for RK3288 SoC.
>
> Fix the VPU IOMMU node, which was disabled and lacking
> its power domain property.
>
> Signed-off-by: Ezequiel Garcia
applied for 4.20 (may possibly move to 4.21
Am Freitag, 5. Oktober 2018, 02:12:23 CEST schrieb Ezequiel Garcia:
> Add the Video Processing Unit node for the RK3399 SoC.
>
> Also, fix the VPU IOMMU node, which was disabled and lacking
> its power domain property.
>
> Signed-off-by: Ezequiel Garcia
applied for 4.20 (may possibly move to
Em Mon, 1 Oct 2018 18:19:21 +0100
Dave Stevenson escreveu:
> Hi All,
>
> On Mon, 1 Oct 2018 at 17:32, Ezequiel Garcia wrote:
> >
> > Hi Hans,
> >
> > Thanks for looking into. I remember MJPEG vs. JPEG being a source
> > of confusion for me a few years ago, so clarification is greatly
> >
On Fri, 2018-10-05 at 08:09 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 4 Oct 2018 21:12:24 -0300
> Ezequiel Garcia escreveu:
>
> > From: Shunqian Zheng
> >
> > Add V4L2_PIX_FMT_JPEG_RAW format that does not contain
> > JPEG header in the output frame.
> >
> > Signed-off-by: Shunqian Zheng
Em Mon, 01 Oct 2018 08:42:56 -0400
Nicolas Dufresne escreveu:
> Hello Hans,
>
> Le lundi 01 octobre 2018 à 10:43 +0200, Hans Verkuil a écrit :
> > It turns out that we have both JPEG and Motion-JPEG pixel formats defined.
> >
> > Furthermore, some drivers support one, some the other and some
Em Thu, 4 Oct 2018 21:12:24 -0300
Ezequiel Garcia escreveu:
> From: Shunqian Zheng
>
> Add V4L2_PIX_FMT_JPEG_RAW format that does not contain
> JPEG header in the output frame.
>
> Signed-off-by: Shunqian Zheng
> Signed-off-by: Ezequiel Garcia
> ---
>
Hi Hans,
I like this series, nice work!
On 2018-10-05 09:49:00 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This patch series converts the last remaining drivers that use g/s_crop and
> cropcap to g/s_selection.
>
> The first two patches do some minor code cleanup.
>
> The third patch
Hi Hans,
Thanks for your patch.
On 2018-10-05 09:49:11 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Now vidioc_cropcap is only used to return the pixelaspect, so
> rename it accordingly.
>
> Signed-off-by: Hans Verkuil
For the v4l2 and rcar-vin changes:
Reviewed-by: Niklas Söderlund
On 10/05/18 12:47, Niklas Söderlund wrote:
> Hi Hans,
>
> Thanks for your work.
>
> On 2018-10-05 09:49:10 +0200, Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> Now that all drivers have dropped vidioc_g/s_crop we can remove
>> support for them in the V4L2 core.
>>
>> Signed-off-by: Hans
Hi Hans,
Thanks for your work.
On 2018-10-05 09:49:10 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Now that all drivers have dropped vidioc_g/s_crop we can remove
> support for them in the V4L2 core.
>
> Signed-off-by: Hans Verkuil
If the quirk patch hurt my head this makes me smile!
Hi Hans,
Thanks for your patch.
On 2018-10-05 09:49:03 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Some old Samsung drivers use the legacy crop API incorrectly:
> the crop and compose targets are swapped. Normally VIDIOC_G_CROP
> will return the CROP rectangle of a CAPTURE stream and
Hi Mauro,
On Fri, Oct 05, 2018 at 06:29:36AM -0400, Mauro Carvalho Chehab wrote:
> There are several coding style issues at those definitions,
> and the previous patchset added even more.
>
> Address the trivial ones by first calling:
>
> ./scripts/checkpatch.pl --strict --fix-inline
>
Em Fri, 5 Oct 2018 13:08:25 +0300
Sakari Ailus escreveu:
> > > This is still over 80 here. I think we could think of abbreviating what's
> > > in the function name, not limiting to the endpoint. I think I'd prefer to
> > > leave that for 4.21 as there's not much time anymore.
> >
> > Yes, I
Em Fri, 5 Oct 2018 13:06:04 +0300
Sakari Ailus escreveu:
> > > > - unsigned int i;
> > >
> > > I'd like to keep this here.
> >
> > Why? IMHO, it makes harder to read (yet, if you insist, I'm ok with
> > both ways).
>
> Generally loop, temporary, return etc. variables are nice
Hi Hans,
Thanks for your patch.
On 2018-10-05 09:49:02 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This ensures that they won't be used in kernel code.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Niklas Söderlund
> ---
> include/uapi/linux/v4l2-common.h | 28
Hi Mauro,
On Fri, Oct 05, 2018 at 07:12:02AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 5 Oct 2018 10:55:58 +0300
> Sakari Ailus escreveu:
...
> > > @@ -436,8 +437,7 @@ static int __v4l2_fwnode_endpoint_parse(struct
> > > fwnode_handle *fwnode,
> > > if (mbus_type !=
Hi Marek,
On Fri, Oct 05, 2018 at 10:01:41AM +0200, Marek Szyprowski wrote:
> Commits 03fbdb2fc2b8 ("media: move videobuf2 to drivers/media/common")
> and 7952be9b6ece ("media: drivers/media/common/videobuf2: rename from
> videobuf") moved videobuf2 framework source code finally to
>
Hi Hans,
Thanks for your work.
On 2018-10-05 09:49:01 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Drop the deprecated _ACTIVE part.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/v4l2-core/v4l2-ioctl.c | 8
> 1 file changed, 4
Em Fri, 5 Oct 2018 10:55:58 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Thu, Oct 04, 2018 at 06:13:46PM -0400, Mauro Carvalho Chehab wrote:
> > There are several coding style issues at those definitions,
> > and the previous patchset added even more.
> >
> > Address the trivial ones by
On Fri, Oct 05, 2018 at 06:52:20AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 5 Oct 2018 11:01:18 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > Feel free to ignore the comments on the first patch regarding the functions
> > below. There are other issues there though.
> >
> > On
On Fri, Oct 05, 2018 at 06:54:49AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 5 Oct 2018 11:03:10 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > On Thu, Oct 04, 2018 at 06:13:48PM -0400, Mauro Carvalho Chehab wrote:
> > > The v4l2_fwnode_reference_parse_int_props() has a big name,
Em Fri, 5 Oct 2018 11:03:10 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Thu, Oct 04, 2018 at 06:13:48PM -0400, Mauro Carvalho Chehab wrote:
> > The v4l2_fwnode_reference_parse_int_props() has a big name, causing
> > it to cause coding style warnings. Also, it depends on a const
> > struct
Em Fri, 5 Oct 2018 11:01:18 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> Feel free to ignore the comments on the first patch regarding the functions
> below. There are other issues there though.
>
> On Thu, Oct 04, 2018 at 06:13:47PM -0400, Mauro Carvalho Chehab wrote:
> > There is already a
Hi Hans,
On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> > The video_i2c_data is allocated by kzalloc and released by the video
> > device's release callback. The release callback is called when
> > video_unregister_device() is
On Fri, Oct 05, 2018 at 09:37:11AM +0200, Hans Verkuil wrote:
> On 10/05/2018 12:21 AM, Sean Young wrote:
> > An RC device is does not need to be called 'RC for'. Simply the name
> > will suffice.
> >
> > Signed-off-by: Sean Young
>
> Reviewed-by: Hans Verkuil
>
> OK if I take this patch? I
On 10/02/18 18:17, Akinobu Mita wrote:
> 2018年10月1日(月) 18:40 Hans Verkuil :
>>
>> On 09/23/2018 06:34 PM, Akinobu Mita wrote:
>>> The video_i2c_data is allocated by kzalloc and released by the video
>>> device's release callback. The release callback is called when
>>> video_unregister_device()
701 - 800 of 69796 matches
Mail list logo
