Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-10 Thread Hans de Goede
Hi, On 08/09/2012 10:03 PM, David Rientjes wrote: On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote: Yeah, that would work as well, although the code would look uglier. IMHO, using select/depend is better. Agreed, I think it should be depends on LEDS_CLASS rather than select it if there is a

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-09 Thread Mauro Carvalho Chehab
Em 08-08-2012 19:28, David Rientjes escreveu: On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote: [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver This one gives me a build warning if CONFIG_LEDS_CLASS is disabled: ERROR: led_classdev_register

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-09 Thread Hans de Goede
Hi, My bad, sorry about this. Mauro's patch looks good. An alternative fix would be to #ifdefify the led code in the drivers themselves. Regards, Hans On 08/09/2012 01:38 PM, Mauro Carvalho Chehab wrote: Em 08-08-2012 19:28, David Rientjes escreveu: On Tue, 31 Jul 2012, Mauro Carvalho

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-09 Thread Mauro Carvalho Chehab
Em 09-08-2012 09:00, Hans de Goede escreveu: Hi, My bad, sorry about this. Mauro's patch looks good. Hmm... menuconfig NEW_LEDS bool LED Support help Say Y to enable Linux LED support. This allows control of supported LEDs from both userspace and

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-09 Thread David Rientjes
On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote: Yeah, that would work as well, although the code would look uglier. IMHO, using select/depend is better. Agreed, I think it should be depends on LEDS_CLASS rather than select it if there is a hard dependency that cannot be fixed with

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-08 Thread David Rientjes
On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote: [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver This one gives me a build warning if CONFIG_LEDS_CLASS is disabled: ERROR: led_classdev_register [drivers/media/radio/shark2.ko] undefined! ERROR:

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-07-31 Thread Mauro Carvalho Chehab
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Em 31-07-2012 12:15, Mauro Carvalho Chehab escreveu: Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media v4l_for_linus For the second part of media patches: - radio API: add support to