Re: [PATCH/RFC 26/48] videodev2.h: Add request field to v4l2_pix_format_mplane

2015-12-20 Thread Laurent Pinchart
Hi Geert, On Friday 18 December 2015 18:37:51 Geert Uytterhoeven wrote: > On Fri, Dec 18, 2015 at 6:16 PM, Laurent Pinchart wrote: > >> > @@ -1987,7 +1988,8 @@ struct v4l2_pix_format_mplane { > >> > __u8ycbcr_enc; > >> > __u8

Re: [PATCH/RFC 26/48] videodev2.h: Add request field to v4l2_pix_format_mplane

2015-12-18 Thread Hans Verkuil
Hi Laurent, On 12/17/2015 09:40 AM, Laurent Pinchart wrote: > Let userspace specify a request ID when getting or setting formats. The > support is limited to the multi-planar API at the moment, extending it > to the single-planar API is possible if needed. > > From a userspace point of view the

Re: [PATCH/RFC 26/48] videodev2.h: Add request field to v4l2_pix_format_mplane

2015-12-18 Thread Laurent Pinchart
Hi Hans, Thank you for the review. On Friday 18 December 2015 12:18:26 Hans Verkuil wrote: > On 12/17/2015 09:40 AM, Laurent Pinchart wrote: > > Let userspace specify a request ID when getting or setting formats. The > > support is limited to the multi-planar API at the moment, extending it > >

Re: [PATCH/RFC 26/48] videodev2.h: Add request field to v4l2_pix_format_mplane

2015-12-18 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Dec 18, 2015 at 6:16 PM, Laurent Pinchart wrote: >> > @@ -1987,7 +1988,8 @@ struct v4l2_pix_format_mplane { >> > >> > __u8ycbcr_enc; >> > __u8quantization; >> > __u8