Re: [PATCH] [media] tea5764: Fix module parameter permissions

2011-07-13 Thread Mauro Carvalho Chehab
Em 11-07-2011 09:25, Fabio Belavenuto escreveu: Hi, I'm the author. Sorry for my bad english, I'm from Brazil. :D Yes, the intent of the 1 is to set the default value, in case compile built-in. I like the module to be generic, decided to choose enabled by default. Fábio 2011/7/11

Re: [PATCH] [media] tea5764: Fix module parameter permissions

2011-07-11 Thread Jean Delvare
Hi Andy, On Friday 08 July 2011 12:34:38 pm Andy Walls wrote: Jean Delvare jdelv...@suse.de wrote: The third parameter of module_param is supposed to represent sysfs file permissions. A value of 1 leads to the following: $ ls -l /sys/module/radio_tea5764/parameters/ total 0 -x 1

Re: [PATCH] [media] tea5764: Fix module parameter permissions

2011-07-11 Thread Fabio Belavenuto
Hi, I'm the author. Sorry for my bad english, I'm from Brazil. :D Yes, the intent of the 1 is to set the default value, in case compile built-in. I like the module to be generic, decided to choose enabled by default. Fábio 2011/7/11 Jean Delvare jdelv...@suse.de: Hi Andy, On Friday 08 July

Re: [PATCH] [media] tea5764: Fix module parameter permissions

2011-07-08 Thread Andy Walls
Jean Delvare jdelv...@suse.de wrote: The third parameter of module_param is supposed to represent sysfs file permissions. A value of 1 leads to the following: $ ls -l /sys/module/radio_tea5764/parameters/ total 0 -x 1 root root 4096 Jul 8 09:17 use_xtal I am changing it to 0 to align