Re: [PATCH] media: ov5640: fix frame interval enumeration

Hi Mauro, Thanks for review, I've just sent a v2 to rearrange code as per your suggestion and also add a NULL test case for mode even if this should not happen. Best regards, Hugues. On 03/08/2018 11:46 AM, Mauro Carvalho Chehab wrote: > Em Thu, 8 Mar 2018 07:39:09 -0300 > Mauro Carvalho

Re: [PATCH] media: ov5640: fix frame interval enumeration

Em Thu, 8 Mar 2018 07:39:09 -0300 Mauro Carvalho Chehab escreveu: > Also, if this function starts returning NULL, I suspect that you also > need to change ov5640_s_frame_interval(), as currently it is called > at ov5640_s_frame_interval() as: > > sensor->current_mode =

Re: [PATCH] media: ov5640: fix frame interval enumeration

Em Thu, 8 Mar 2018 10:01:59 +0100 Hugues Fruchet escreveu: > Driver must reject frame interval enumeration of unsupported resolution. > This was detected by v4l2-compliance format ioctl test: > v4l2-compliance Format ioctls: > info: found 2 frameintervals for pixel