Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Wed, Apr 06, 2011 at 11:38:54AM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 11:25:57AM -0700, Andres Salomon wrote: We've been faced with the problem of being able to pass both MFD related data and a platform_data pointer to some of those drivers. Squeezing the MFD bits in the

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Felipe Balbi
Hi, On Wed, Apr 06, 2011 at 03:09:00PM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 09:59:02PM +0300, Felipe Balbi wrote: Hi, On Wed, Apr 06, 2011 at 08:47:34PM +0200, Samuel Ortiz wrote: What is a MFD cell pointer and why is it needed in struct device? An MFD cell is an MFD

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Thu, Apr 07, 2011 at 03:40:23PM +0200, Samuel Ortiz wrote: Hi Felipe, On Wed, Apr 06, 2011 at 09:59:02PM +0300, Felipe Balbi wrote: Hi, On Wed, Apr 06, 2011 at 08:47:34PM +0200, Samuel Ortiz wrote: What is a MFD cell pointer and why is it needed in struct device? An MFD

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Samuel Ortiz
On Thu, Apr 07, 2011 at 07:35:15AM -0700, Grant Likely wrote: Below is a patch for the Xilinx SPI example. Although this would fix the issue, we'd still have to do that on device per device basis. I had a similar solution where MFD drivers would set a flag for sub drivers that don't need

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Mon, Apr 4, 2011 at 8:04 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Apr 04, 2011 at 12:03:15PM +0200, Samuel Ortiz wrote: diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h index d96db98..734d254 100644 --- a/include/linux/platform_device.h +++

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Thu, Apr 07, 2011 at 05:03:23PM +0200, Samuel Ortiz wrote: On Thu, Apr 07, 2011 at 07:35:15AM -0700, Grant Likely wrote: Below is a patch for the Xilinx SPI example. Although this would fix the issue, we'd still have to do that on device per device basis. I had a similar solution

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Samuel Ortiz
On Mon, Apr 04, 2011 at 09:04:29PM -0600, Grant Likely wrote: The second step would be to get rid of mfd_get_data() and have all subdrivers going back to the regular platform_data way. They would no longer be dependant on the MFD code except for those who really need it. In that case

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Greg KH
On Wed, Apr 06, 2011 at 05:23:23PM +0200, Samuel Ortiz wrote: --- a/include/linux/device.h +++ b/include/linux/device.h @@ -33,6 +33,7 @@ struct class; struct subsys_private; struct bus_type; struct device_node; +struct mfd_cell; struct bus_attribute { struct attribute

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Samuel Ortiz
Hi Greg, On Wed, Apr 06, 2011 at 08:58:05AM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 05:23:23PM +0200, Samuel Ortiz wrote: --- a/include/linux/device.h +++ b/include/linux/device.h @@ -33,6 +33,7 @@ struct class; struct subsys_private; struct bus_type; struct device_node;

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Ben Hutchings
On Wed, 2011-04-06 at 19:05 +0200, Samuel Ortiz wrote: Hi Greg, On Wed, Apr 06, 2011 at 08:58:05AM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 05:23:23PM +0200, Samuel Ortiz wrote: --- a/include/linux/device.h +++ b/include/linux/device.h @@ -33,6 +33,7 @@ struct class; struct

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Samuel Ortiz
Hi Ben, On Wed, Apr 06, 2011 at 06:16:49PM +0100, Ben Hutchings wrote: So, adding an MFD cell pointer to the device structure allows us to cleanly pass both pieces of information, while keeping all the MFD sub drivers independant from the MFD core if they want/can. Why isn't an MFD the

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Greg KH
On Wed, Apr 06, 2011 at 07:05:38PM +0200, Samuel Ortiz wrote: Hi Greg, On Wed, Apr 06, 2011 at 08:58:05AM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 05:23:23PM +0200, Samuel Ortiz wrote: --- a/include/linux/device.h +++ b/include/linux/device.h @@ -33,6 +33,7 @@ struct class;

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Ben Hutchings
On Wed, 2011-04-06 at 19:51 +0200, Samuel Ortiz wrote: Hi Ben, On Wed, Apr 06, 2011 at 06:16:49PM +0100, Ben Hutchings wrote: So, adding an MFD cell pointer to the device structure allows us to cleanly pass both pieces of information, while keeping all the MFD sub drivers

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Andres Salomon
On Wed, 6 Apr 2011 10:56:47 -0700 Greg KH gre...@suse.de wrote: On Wed, Apr 06, 2011 at 07:05:38PM +0200, Samuel Ortiz wrote: Hi Greg, On Wed, Apr 06, 2011 at 08:58:05AM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 05:23:23PM +0200, Samuel Ortiz wrote: --- a/include/linux/device.h

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Greg KH
On Wed, Apr 06, 2011 at 11:25:57AM -0700, Andres Salomon wrote: We've been faced with the problem of being able to pass both MFD related data and a platform_data pointer to some of those drivers. Squeezing the MFD bits in the sub driver platform_data pointer doesn't work for drivers

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Samuel Ortiz
On Wed, Apr 06, 2011 at 10:56:47AM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 07:05:38PM +0200, Samuel Ortiz wrote: Hi Greg, On Wed, Apr 06, 2011 at 08:58:05AM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 05:23:23PM +0200, Samuel Ortiz wrote: --- a/include/linux/device.h +++

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Felipe Balbi
Hi, On Wed, Apr 06, 2011 at 08:47:34PM +0200, Samuel Ortiz wrote: What is a MFD cell pointer and why is it needed in struct device? An MFD cell is an MFD instantiated device. MFD (Multi Function Device) drivers instantiate platform devices. Those devices drivers sometimes need a

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Greg KH
On Wed, Apr 06, 2011 at 09:59:02PM +0300, Felipe Balbi wrote: Hi, On Wed, Apr 06, 2011 at 08:47:34PM +0200, Samuel Ortiz wrote: What is a MFD cell pointer and why is it needed in struct device? An MFD cell is an MFD instantiated device. MFD (Multi Function Device) drivers

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-04 Thread Samuel Ortiz
On Fri, Apr 01, 2011 at 05:58:44PM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 5:52 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon dilin...@queued.net wrote: On Fri, 1 Apr

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-04 Thread Grant Likely
On Mon, Apr 04, 2011 at 12:03:15PM +0200, Samuel Ortiz wrote: On Fri, Apr 01, 2011 at 05:58:44PM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 5:52 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 11:47

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Samuel Ortiz
Hi Grant, On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant Likely wrote: On Wed, Feb 02, 2011 at 08:08:12PM -0800, Andres Salomon wrote: No need to explicitly set the cell's platform_data/data_size. In this case, move the various platform_data pointers to driver_data. All of the

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Andres Salomon
On Fri, 1 Apr 2011 13:20:31 +0200 Samuel Ortiz sa...@linux.intel.com wrote: Hi Grant, On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant Likely wrote: [...] Gah. Not all devices instantiated via mfd will be an mfd device, which means that the driver may very well expect an *entirely

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Grant Likely
On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon dilin...@queued.net wrote: On Fri, 1 Apr 2011 13:20:31 +0200 Samuel Ortiz sa...@linux.intel.com wrote: Hi Grant, On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant Likely wrote: [...] Gah.  Not all devices instantiated via mfd will be an mfd

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Grant Likely
On Fri, Apr 1, 2011 at 11:56 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon dilin...@queued.net wrote: On Fri, 1 Apr 2011 13:20:31 +0200 Samuel Ortiz sa...@linux.intel.com wrote: Hi Grant, On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Samuel Ortiz
On Fri, Apr 01, 2011 at 10:47:56AM -0700, Andres Salomon wrote: On Fri, 1 Apr 2011 13:20:31 +0200 Samuel Ortiz sa...@linux.intel.com wrote: Hi Grant, On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant Likely wrote: [...] Gah. Not all devices instantiated via mfd will be an mfd device,

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Samuel Ortiz
On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon dilin...@queued.net wrote: On Fri, 1 Apr 2011 13:20:31 +0200 Samuel Ortiz sa...@linux.intel.com wrote: Hi Grant, On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant Likely wrote:

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Grant Likely
On Fri, Apr 1, 2011 at 5:52 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon dilin...@queued.net wrote: On Fri, 1 Apr 2011 13:20:31 +0200 Samuel Ortiz sa...@linux.intel.com wrote:

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Andres Salomon
On Fri, 1 Apr 2011 17:58:44 -0600 Grant Likely grant.lik...@secretlab.ca wrote: On Fri, Apr 1, 2011 at 5:52 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon dilin...@queued.net

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-03-31 Thread Grant Likely
On Wed, Feb 02, 2011 at 08:08:12PM -0800, Andres Salomon wrote: No need to explicitly set the cell's platform_data/data_size. In this case, move the various platform_data pointers to driver_data. All of the clients which make use of it are also changed. Signed-off-by: Andres Salomon