Hi,
sorry not to have answered sooner.
On Tuesday 09 June 2009 00:05:10 Karicheri, Muralidharan wrote:
+
+/* register access routines */
+static inline u32 regr(u32 offset)
+{
+ if (offset = ccdc_addr_size)
This should be .
+ return __raw_readl(ccdc_base_addr +
Laurent,
Laurent,
Thanks for reviewing this. See my response below for few comments. Rest of them
I have incorporated into my next patch.
Murali Karicheri
Software Design Engineer
Texas Instruments Inc.
Germantown, MD 20874
Phone : 301-515-3736
email: m-kariche...@ti.com
+
+/* register
Hi,
On Tuesday 02 June 2009 02:12:41 Kevin Hilman wrote:
Karicheri, Muralidharan m-kariche...@ti.com writes:
Thanks for reviewing this. I have not gone through all of your comments,
but would like to respond to the following one first. I will respond to
the rest as I do the rework.
My first reaction to this is... no. I'm reluctant to have a bunch of
driver specific hooks in the core davinci SoC specific code. I'd much
rather see this stuff kept along with the driver in drivers/media/*
and abstracted as necessary there.
I agree with Kevin on this. arch/* is mostly
Laurent,
Thanks for reviewing this. I have not gone through all of your comments, but
would like to respond to the following one first. I will respond to the rest as
I do the rework.
I've had a quick look at the DM355 and DM6446 datasheets. The CCDC and VPSS
registers share the same memory
Karicheri, Muralidharan m-kariche...@ti.com writes:
Laurent,
Thanks for reviewing this. I have not gone through all of your comments, but
would like to respond to the following one first. I will respond to the rest
as I do the rework.
I've had a quick look at the DM355 and DM6446
On Thursday 28 May 2009 15:18:17 Laurent Pinchart wrote:
Hi,
most comments here apply to the DM6446 CCDC module as well. Generic
comments apply throughout the source code.
Hans, I'd appreciate if you could review my comments, as some of them
might made according to personal preferences more
