Re: [PATCH v5] media: imx: add mem2mem device

2018-12-06 Thread Steve Longerbeam
Hi Hans, On 12/6/18 4:32 AM, Hans Verkuil wrote: On 12/06/18 00:13, Steve Longerbeam wrote: On 12/5/18 10:50 AM, Hans Verkuil wrote: On 12/05/2018 02:20 AM, Steve Longerbeam wrote: Hi Hans, Philipp, One comment on my side... On 12/3/18 7:21 AM, Hans Verkuil wrote: +void

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-06 Thread Hans Verkuil
On 12/06/18 00:13, Steve Longerbeam wrote: > > > On 12/5/18 10:50 AM, Hans Verkuil wrote: >> On 12/05/2018 02:20 AM, Steve Longerbeam wrote: >>> Hi Hans, Philipp, >>> >>> One comment on my side... >>> >>> On 12/3/18 7:21 AM, Hans Verkuil wrote: > +void

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-05 Thread Steve Longerbeam
On 12/5/18 10:50 AM, Hans Verkuil wrote: On 12/05/2018 02:20 AM, Steve Longerbeam wrote: Hi Hans, Philipp, One comment on my side... On 12/3/18 7:21 AM, Hans Verkuil wrote: +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev) +{ + struct mem2mem_priv *priv =

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-05 Thread Hans Verkuil
On 12/05/2018 02:20 AM, Steve Longerbeam wrote: > Hi Hans, Philipp, > > One comment on my side... > > On 12/3/18 7:21 AM, Hans Verkuil wrote: >> >>> +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev) >>> +{ >>> + struct mem2mem_priv *priv = to_mem2mem_priv(vdev); >>>

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-04 Thread Steve Longerbeam
Hi Hans, Philipp, One comment on my side... On 12/3/18 7:21 AM, Hans Verkuil wrote: +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev) +{ + struct mem2mem_priv *priv = to_mem2mem_priv(vdev); + struct video_device *vfd = priv->vdev.vfd; + +

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-03 Thread Hans Verkuil
On 12/03/2018 12:48 PM, Philipp Zabel wrote: > Add a single imx-media mem2mem video device that uses the IPU IC PP > (image converter post processing) task for scaling and colorspace > conversion. > On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. > > The hardware only