Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-14 Thread Thierry Reding
On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: [...] diff --git a/include/linux/of_display_timings.h b/include/linux/of_display_timings.h [...] +#ifndef __LINUX_OF_DISPLAY_TIMINGS_H +#define __LINUX_OF_DISPLAY_TIMINGS_H + +#include linux/display_timing.h + +#define

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Steffen Trumtrar
Hi! On Mon, Nov 12, 2012 at 07:58:40PM +0100, Sascha Hauer wrote: Hi Steffen, You lose memory in several places: On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: +static struct display_timing *of_get_display_timing(struct device_node *np) +{ + struct display_timing

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Steffen Trumtrar
On Mon, Nov 12, 2012 at 11:00:37PM +0400, Alexey Klimov wrote: Hello Steffen, On Mon, Nov 12, 2012 at 7:37 PM, Steffen Trumtrar s.trumt...@pengutronix.de wrote: This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Thierry Reding
On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The of_display_timing implementation supports multiple children where each property can have up to 3 values. All

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Steffen Trumtrar
On Mon, Nov 12, 2012 at 01:40:12PM -0700, Stephen Warren wrote: On 11/12/2012 08:37 AM, Steffen Trumtrar wrote: This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The of_display_timing implementation supports multiple children where

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Stephen Warren
On 11/13/2012 04:08 AM, Thierry Reding wrote: On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The of_display_timing implementation supports multiple children where each

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Thierry Reding
On Tue, Nov 13, 2012 at 10:46:53AM -0700, Stephen Warren wrote: On 11/13/2012 04:08 AM, Thierry Reding wrote: On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Mitch Bradley
On 11/13/2012 7:51 AM, Thierry Reding wrote: On Tue, Nov 13, 2012 at 10:46:53AM -0700, Stephen Warren wrote: On 11/13/2012 04:08 AM, Thierry Reding wrote: On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: This adds support for reading display timings from DT or/and convert one

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Thierry Reding
On Tue, Nov 13, 2012 at 08:13:31AM -1000, Mitch Bradley wrote: On 11/13/2012 7:51 AM, Thierry Reding wrote: On Tue, Nov 13, 2012 at 10:46:53AM -0700, Stephen Warren wrote: On 11/13/2012 04:08 AM, Thierry Reding wrote: On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: This