Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Sakari Ailus
On Tue, Dec 19, 2017 at 12:31:46PM -0200, Fabio Estevam wrote: > On Tue, Dec 19, 2017 at 11:43 AM, Sakari Ailus wrote: > > > Both seem to exist. See e.g. c3a3d1d6b8b363a02234e5564692db3647f183e6 . > > This patch fixes .h files to use /* SPDX style comment, which is the >

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Fabio Estevam
On Tue, Dec 19, 2017 at 11:43 AM, Sakari Ailus wrote: > Both seem to exist. See e.g. c3a3d1d6b8b363a02234e5564692db3647f183e6 . This patch fixes .h files to use /* SPDX style comment, which is the recommendation. .c files should use // SPDX style.

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Sakari Ailus
On Tue, Dec 19, 2017 at 11:19:06AM -0200, Fabio Estevam wrote: > Hi Sakari, > > On Tue, Dec 19, 2017 at 11:05 AM, Sakari Ailus wrote: > > > I guess it depends on who do you ask and when. Looking at what has been > > recently merged to media tree master, the latter is

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Fabio Estevam
Hi Sakari, On Tue, Dec 19, 2017 at 11:05 AM, Sakari Ailus wrote: > I guess it depends on who do you ask and when. Looking at what has been > recently merged to media tree master, the latter is preferred. Just did 'git grep SPDX drivers/media' and it consistently shows //

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Sakari Ailus
On Tue, Dec 19, 2017 at 10:50:44AM -0200, Fabio Estevam wrote: > Hi Sakari, > > On Tue, Dec 19, 2017 at 7:22 AM, Sakari Ailus wrote: > > On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote: > >> The ov7740 (color) image sensor is a high performance VGA CMOS > >>

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Fabio Estevam
Hi Sakari, On Tue, Dec 19, 2017 at 7:22 AM, Sakari Ailus wrote: > On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote: >> The ov7740 (color) image sensor is a high performance VGA CMOS >> image snesor, which supports for output formats: RAW RGB and YUV >> and image

RE: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Wenyou.Yang
nux Media > Mailing List > <linux-media@vger.kernel.org>; Songjun Wu <songjun...@microchip.com> > Subject: Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver > > On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote: > > The ov7740 (color) im

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Sakari Ailus
On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote: > The ov7740 (color) image sensor is a high performance VGA CMOS > image snesor, which supports for output formats: RAW RGB and YUV > and image sizes: VGA, and QVGA, CIF and any size smaller. > > Signed-off-by: Songjun Wu

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-19 Thread Sakari Ailus
r.kernel.org; Jonathan Corbet > > <cor...@lwn.net>; Hans Verkuil <hverk...@xs4all.nl>; linux-arm- > > ker...@lists.infradead.org; Linux Media Mailing List > me...@vger.kernel.org>; Songjun Wu <songjun...@microchip.com> > > Subject: Re: [PATCH v9

RE: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-18 Thread Wenyou.Yang
g; Linux Media Mailing List me...@vger.kernel.org>; Songjun Wu <songjun...@microchip.com> > Subject: Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver > > Hi Wenyou, > > Wenyou Yang wrote: > ... > > +static int ov7740_start_streaming(struct ov7740

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

2017-12-17 Thread Sakari Ailus
Hi Wenyou, Wenyou Yang wrote: ... > +static int ov7740_start_streaming(struct ov7740 *ov7740) > +{ > + int ret; > + > + if (ov7740->fmt) { > + ret = regmap_multi_reg_write(ov7740->regmap, > + ov7740->fmt->regs, > +