Re: [RFC PATCH 1/9] media: add request API core and UAPI

On 02/02/2018 08:33 AM, Sakari Ailus wrote: +struct media_request_entity_data * +media_request_get_entity_data(struct media_request *req, + struct media_entity *entity, void *fh) >>> >>> This makes the assumption that request data is bound to entities.

Re: [RFC PATCH 1/9] media: add request API core and UAPI

On Fri, Feb 2, 2018 at 4:33 PM, Sakari Ailus wrote: >> >> +/** >> >> + * struct media_request_queue - queue of requests >> >> + * >> >> + * @mdev:media_device that manages this queue >> >> + * @ops: implementation of the queue >> >> + * @mutex: protects

Re: [RFC PATCH 1/9] media: add request API core and UAPI

Hi Alexandre, On Tue, Jan 30, 2018 at 01:23:05PM +0900, Alexandre Courbot wrote: > Hi Sakari, thanks for the review! > > The version you reviewed is not the latest one, but I suppose most of > your comments still apply. > > On Fri, Jan 26, 2018 at 5:39 PM, Sakari Ailus

Re: [RFC PATCH 1/9] media: add request API core and UAPI

Hi Sakari, thanks for the review! The version you reviewed is not the latest one, but I suppose most of your comments still apply. On Fri, Jan 26, 2018 at 5:39 PM, Sakari Ailus wrote: > Hi Alexandre, > > I remember it was discussed that the work after the V4L2 jobs API

Re: [RFC PATCH 1/9] media: add request API core and UAPI

Hi Alexandre, I remember it was discussed that the work after the V4L2 jobs API would continue from the existing request API patches. I see that at least the rather important support for events is missing in this version. Why was it left out? I also see that variable size IOCTL argument support

Re: [RFC PATCH 1/9] media: add request API core and UAPI

Hi Alexandre, A quick review: I'm primarily concentrating on the uAPI as that is the most critical part to get right at this stage. On 12/15/17 08:56, Alexandre Courbot wrote: > The request API provides a way to group buffers and device parameters > into units of work to be queued and executed.

Re: [RFC PATCH 1/9] media: add request API core and UAPI

Alexandre: On Fri, Dec 15, 2017 at 8:56 AM, Alexandre Courbot wrote: > The request API provides a way to group buffers and device parameters > into units of work to be queued and executed. This patch introduces the > UAPI and core framework. > > This patch is based on the