Re: iMon Knob driver issue

2013-01-01 Thread Mauro Carvalho Chehab
Em Sat, 29 Dec 2012 14:01:57 +0100 Alexandre Lissy lissyx+mo...@lissyx.dyndns.org escreveu: From cca7718a9902a4d5cffbf158b5853980a08ef930 Mon Sep 17 00:00:00 2001 From: Alexandre Lissy alexandreli...@free.fr Date: Sun, 2 Sep 2012 20:35:20 +0200 Subject: [PATCH] fix: iMon Knob event

Re: iMon Knob driver issue

2013-01-01 Thread Alexandre LISSY
Hello, I had the same opinion than you at first, yet I found this webpage while searching for a fix : http://www.arm.linux.org.uk/docs/faqs/signedchar.php. One line especially: The above code is actually buggy in that it assumes that the type char is equivalent to signed char. The C standards do

Re: iMon Knob driver issue

2012-12-29 Thread Alexey Klimov
Hello Alexandre, On Sat, Dec 29, 2012 at 4:08 PM, Alexandre LISSY alexandreli...@free.fr wrote: Hello, Please find attached a small patch for the iMon Knob driver. I've been Could you please also add your Signed-off-by to the patch? It looks like it's missed. -- Best regards, Klimov Alexey

Re: iMon Knob driver issue

2012-12-29 Thread Alexandre Lissy
Le 29/12/2012 13:31, Alexey Klimov a écrit : Hello Alexandre, On Sat, Dec 29, 2012 at 4:08 PM, Alexandre LISSY alexandreli...@free.fr wrote: Hello, Please find attached a small patch for the iMon Knob driver. I've been Could you please also add your Signed-off-by to the patch? It looks