Re: sparse: ioctl defines and error: bad integer constant expression

2014-04-03 Thread Christopher Li
On Tue, Apr 1, 2014 at 10:06 AM, Hans Verkuil hverk...@xs4all.nl wrote: For all my test cases: Signed-off-by: Hans Verkuil hans.verk...@cisco.com All 3 test cases added. Chris -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

Re: sparse: ioctl defines and error: bad integer constant expression

2014-04-01 Thread Christopher Li
On Mon, Mar 31, 2014 at 10:22 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Mon, Mar 31, 2014 at 1:06 AM, Hans Verkuil hverk...@xs4all.nl wrote: Chris, can you please add this to the test cases since Hans did the work to create a nice small test-case? Sure, I want to add them to

Re: sparse: ioctl defines and error: bad integer constant expression

2014-04-01 Thread Hans Verkuil
On 04/01/2014 06:48 PM, Christopher Li wrote: On Mon, Mar 31, 2014 at 10:22 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Mon, Mar 31, 2014 at 1:06 AM, Hans Verkuil hverk...@xs4all.nl wrote: Chris, can you please add this to the test cases since Hans did the work to create a

Re: sparse: ioctl defines and error: bad integer constant expression

2014-03-31 Thread Hans Verkuil
On 03/15/2014 12:59 PM, Hans Verkuil wrote: Hi! Here is another sparse error that I get when running sparse over drivers/media/v4l2-core/v4l2-ioctl.c: drivers/media/v4l2-core/v4l2-ioctl.c:2043:9: error: bad integer constant expression drivers/media/v4l2-core/v4l2-ioctl.c:2044:9: error:

Re: sparse: ioctl defines and error: bad integer constant expression

2014-03-31 Thread Linus Torvalds
On Mon, Mar 31, 2014 at 1:06 AM, Hans Verkuil hverk...@xs4all.nl wrote: Running sparse over this gives: error: bad integer constant expression So technically sparse is correct in this case. The kernel ends up doing some questionable things that gcc allows. The index in an assignment