Re: SOLO6x10: fix a race in IRQ handler.

2014-11-26 Thread Ismael Luceno
On Fri, 14 Nov 2014 13:35:06 +0100 khal...@piap.pl (Krzysztof Hałasa) wrote: The IRQs have to be acknowledged before they are serviced, otherwise some events may be skipped. Also, acknowledging IRQs just before returning from the handler doesn't leave enough time for the device to deassert the

patchwork on solo6x10: fix a race in IRQ handler

2014-11-17 Thread Andrey Utkin
Dear linux-media maintainers, I fail to do `git am` on mbox-formatted patch downloadable from https://patchwork.linuxtv.org/patch/26970/ so i worry if the Krzyztof's patch i resubmitted is well-formed, and whether you are fine with integration of this patch to media_tree and further to upstream.

Re: patchwork on solo6x10: fix a race in IRQ handler

2014-11-17 Thread Hans Verkuil
On 11/17/2014 05:47 PM, Andrey Utkin wrote: Dear linux-media maintainers, I fail to do `git am` on mbox-formatted patch downloadable from https://patchwork.linuxtv.org/patch/26970/ so i worry if the Krzyztof's patch i resubmitted is well-formed, and whether you are fine with integration of

Re: SOLO6x10: fix a race in IRQ handler.

2014-11-15 Thread Andrey Utkin
Krzysztof, it seems to really help. The host is working stable for 2.5 hours at the moment, with original framerate of 2 fps. Thank you very much. -- Andrey Utkin -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: SOLO6x10: fix a race in IRQ handler.

2014-11-15 Thread Hans Verkuil
Hi Andrey, Please always prefix the subject line with [PATCH] when you post a patch. That way it will be picked up by patchwork (https://patchwork.linuxtv.org/project/linux-media/list/) and the patch won't be lost. Can you repost with such a prefix? Thanks! Hans On 11/15/2014 11:34

[PATCH] solo6x10: fix a race in IRQ handler

2014-11-15 Thread Andrey Utkin
From: Krzysztof Hałasa khal...@piap.pl The IRQs have to be acknowledged before they are serviced, otherwise some events may be skipped. Also, acknowledging IRQs just before returning from the handler doesn't leave enough time for the device to deassert the INTx line, and for bridges to propagate

SOLO6x10: fix a race in IRQ handler.

2014-11-14 Thread Krzysztof Hałasa
The IRQs have to be acknowledged before they are serviced, otherwise some events may be skipped. Also, acknowledging IRQs just before returning from the handler doesn't leave enough time for the device to deassert the INTx line, and for bridges to propagate this change. This resulted in twice the

Re: SOLO6x10: fix a race in IRQ handler.

2014-11-14 Thread Andrey Utkin
2014-11-14 16:35 GMT+04:00 Krzysztof Hałasa khal...@piap.pl: The IRQs have to be acknowledged before they are serviced, otherwise some events may be skipped. Also, acknowledging IRQs just before returning from the handler doesn't leave enough time for the device to deassert the INTx line,

Re: SOLO6x10: fix a race in IRQ handler.

2014-11-14 Thread Andrey Utkin
Also while you're at it, and if this really makes sense, you could merge these two writes (unrecognized bits, then recognized bits) to one write act. -- Andrey Utkin -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: SOLO6x10: fix a race in IRQ handler.

2014-11-14 Thread Krzysztof Hałasa
Andrey Utkin andrey.krieger.ut...@gmail.com writes: could you please point to some reading which explains this moment? Or you just know this from experience? The solo device specs are very terse about this, so I considered that it should work fine without regard to how fast we write back to

Re: SOLO6x10: fix a race in IRQ handler.

2014-11-14 Thread Andrey Utkin
2014-11-15 1:33 GMT+04:00 Krzysztof Hałasa khal...@piap.pl: The SOLO IRQ controller does the common thing, all drivers (for chips using the relatively modern write 1 to clear) have to follow this sequence: first ACK the interrupts sources (so they are deasserted, though they can be asserted