Re: cx18 fix patches

2010-01-29 Thread Devin Heitmueller
Hi Andy, On Thu, Jan 28, 2010 at 9:24 PM, Andy Walls awa...@radix.net wrote: Devin, I found interesting system interactions.  On my dual core x86_64 Fedora 12 machine loading an HVR-1600 cold (no firmware has been loaded yet), the pulseaudio daemon opens up a CX23418 ALSA node almost

Re: cx18 fix patches

2010-01-29 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: Hi Andy, On Thu, Jan 28, 2010 at 9:24 PM, Andy Walls awa...@radix.net wrote: Devin, I found interesting system interactions. On my dual core x86_64 Fedora 12 machine loading an HVR-1600 cold (no firmware has been loaded yet), the pulseaudio daemon opens up a

Re: cx18 fix patches

2010-01-29 Thread Devin Heitmueller
On Fri, Jan 29, 2010 at 1:40 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: I doubt it would solve. IMO, having it modular is good, since you may not need cx18 alsa on all devices. Modularity is good, but we really need to rethink about the way we are loading these modules (this applies to

Re: cx18 fix patches

2010-01-29 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: On Fri, Jan 29, 2010 at 1:40 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: I doubt it would solve. IMO, having it modular is good, since you may not need cx18 alsa on all devices. Modularity is good, but we really need to rethink about the way we are loading

Re: cx18 fix patches

2010-01-29 Thread Devin Heitmueller
On Fri, Jan 29, 2010 at 2:59 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: The asynchronous load were added not to improve the boot load time, but to avoid some troubles that happens when the load is synchronous. I don't remember what were the exact trouble, but I suspect that it was

Re: cx18 fix patches

2010-01-28 Thread Andy Walls
On Thu, 2010-01-28 at 00:40 -0200, Mauro Carvalho Chehab wrote: Hi Andy, I've made two fix patches to solve the issues with cx18 compilation. My original intention were to send you an email for your ack. Unfortunately, those got added at the wrong branch and went upstream. That proofs

Re: cx18 fix patches

2010-01-28 Thread Mauro Carvalho Chehab
Andy Walls wrote: Now I'll just review and test tonight (some time between 6:00 - 10:30 p.m. EST) One more error (on x86_64): drivers/media/video/cx18/cx18-alsa-pcm.c: In function ‘cx18_alsa_announce_pcm_data’: drivers/media/video/cx18/cx18-alsa-pcm.c:82: warning: format ‘%d’ expects type

Re: cx18 fix patches

2010-01-28 Thread Andy Walls
On Thu, 2010-01-28 at 00:40 -0200, Mauro Carvalho Chehab wrote: Hi Andy, I've made two fix patches to solve the issues with cx18 compilation. My original intention were to send you an email for your ack. Unfortunately, those got added at the wrong branch and went upstream. That proofs

Re: cx18 fix patches

2010-01-28 Thread Andy Walls
On Fri, 2010-01-29 at 00:08 -0200, Mauro Carvalho Chehab wrote: Andy Walls wrote: Now I'll just review and test tonight (some time between 6:00 - 10:30 p.m. EST) One more error (on x86_64): drivers/media/video/cx18/cx18-alsa-pcm.c: In function ‘cx18_alsa_announce_pcm_data’:

Re: cx18 fix patches

2010-01-28 Thread Mauro Carvalho Chehab
Andy Walls wrote: On Thu, 2010-01-28 at 00:40 -0200, Mauro Carvalho Chehab wrote: Hi Andy, I've made two fix patches to solve the issues with cx18 compilation. My original intention were to send you an email for your ack. Unfortunately, those got added at the wrong branch and went upstream.