[PATCH] em28xx: Reworked probe code to get rid of some hacks (was: Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick))

2011-12-28 Thread Holger Nelson
Reworked device probing to get rid of hacks to guess the maximum size of dvb iso transfer packets. The new code also selects the first alternate config which supports the largest possible iso transfers for dvb. Signed-off-by: Holger Nelson diff --git a/drivers/media/video/em28xx/em28xx-audio.

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-28 Thread Mauro Carvalho Chehab
On 28-12-2011 01:50, Holger Nelson wrote: > On Mon, 26 Dec 2011, Mauro Carvalho Chehab wrote: > >> I'm currently without time right now to work on a patch, but I think that >> several hacks >> inside the em28xx probe should be removed, including the one that detects >> the endpoint >> based on t

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-27 Thread Holger Nelson
On Mon, 26 Dec 2011, Mauro Carvalho Chehab wrote: I'm currently without time right now to work on a patch, but I think that several hacks inside the em28xx probe should be removed, including the one that detects the endpoint based on the packet size. As it is easier to code than to explain in

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-26 Thread Mauro Carvalho Chehab
On 26-12-2011 03:55, Holger Nelson wrote: > Hi! > > On Sun, 25 Dec 2011, Dennis Sperlich wrote: > >> I just tried, replacing >>max_dvb_packet_size = em28xx_isoc_dvb_max_packetsize(dev); >> by >>max_dvb_packet_size = dev->alt_max_pkt_size[1]; >> >> but it did not work. Was this the correct

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-25 Thread Holger Nelson
Hi! On Sun, 25 Dec 2011, Dennis Sperlich wrote: I just tried, replacing max_dvb_packet_size = em28xx_isoc_dvb_max_packetsize(dev); by max_dvb_packet_size = dev->alt_max_pkt_size[1]; but it did not work. Was this the correct replacement? printk(KERN_INFO "dev->alt_max_pkt_size[1] is

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-25 Thread Dennis Sperlich
On 25.12.2011 19:13, Mauro Carvalho Chehab wrote: On 25-12-2011 12:04, Dennis Sperlich wrote: On 25.12.2011 11:52, Mauro Carvalho Chehab wrote: On 24-12-2011 19:58, Dennis Sperlich wrote: Hi, I have a Terratec Cinergy HTC Stick an tried the new support for the DVB-C part. It works for SD mat

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-25 Thread Dennis Sperlich
On 25.12.2011 20:42, Malcolm Priestley wrote: On Sun, 2011-12-25 at 15:11 +0100, Hans Petter Selasky wrote: On Sunday 25 December 2011 15:04:17 Dennis Sperlich wrote: On 25.12.2011 11:52, Mauro Carvalho Chehab wrote: On 24-12-2011 19:58, Dennis Sperlich wrote: Hi, I have a Terratec Cinergy H

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-25 Thread Malcolm Priestley
On Sun, 2011-12-25 at 15:11 +0100, Hans Petter Selasky wrote: > On Sunday 25 December 2011 15:04:17 Dennis Sperlich wrote: > > On 25.12.2011 11:52, Mauro Carvalho Chehab wrote: > > > On 24-12-2011 19:58, Dennis Sperlich wrote: > > >> Hi, > > >> > > >> I have a Terratec Cinergy HTC Stick an tried t

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-25 Thread Mauro Carvalho Chehab
On 25-12-2011 12:04, Dennis Sperlich wrote: > On 25.12.2011 11:52, Mauro Carvalho Chehab wrote: >> On 24-12-2011 19:58, Dennis Sperlich wrote: >>> Hi, >>> >>> I have a Terratec Cinergy HTC Stick an tried the new support for the DVB-C >>> part. It works for SD material (at least for free receivable

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-25 Thread Mauro Carvalho Chehab
On 25-12-2011 12:11, Hans Petter Selasky wrote: > On Sunday 25 December 2011 15:04:17 Dennis Sperlich wrote: >> On 25.12.2011 11:52, Mauro Carvalho Chehab wrote: >>> On 24-12-2011 19:58, Dennis Sperlich wrote: Hi, I have a Terratec Cinergy HTC Stick an tried the new support for the >

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-25 Thread Devin Heitmueller
On Sun, Dec 25, 2011 at 9:11 AM, Hans Petter Selasky wrote: > These numbers should not be hardcoded, but extracted from the USB endpoint > descriptor! > > --HPS Hans is correct. I only hard-coded it at 564 as a quick hack when I was bootstrapping the em2784 support. The code really should be cl

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-25 Thread Hans Petter Selasky
On Sunday 25 December 2011 15:04:17 Dennis Sperlich wrote: > On 25.12.2011 11:52, Mauro Carvalho Chehab wrote: > > On 24-12-2011 19:58, Dennis Sperlich wrote: > >> Hi, > >> > >> I have a Terratec Cinergy HTC Stick an tried the new support for the > >> DVB-C part. It works for SD material (at least

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-25 Thread Dennis Sperlich
On 25.12.2011 11:52, Mauro Carvalho Chehab wrote: On 24-12-2011 19:58, Dennis Sperlich wrote: Hi, I have a Terratec Cinergy HTC Stick an tried the new support for the DVB-C part. It works for SD material (at least for free receivable stations, I tried afair only QAM64), but did not for HD sta

Re: em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-25 Thread Mauro Carvalho Chehab
On 24-12-2011 19:58, Dennis Sperlich wrote: > Hi, > > I have a Terratec Cinergy HTC Stick an tried the new support for the DVB-C > part. It works for SD material (at least for free receivable stations, I > tried afair only QAM64), but did not for HD stations (QAM256). I have only > access to un

em28xx_isoc_dvb_max_packetsize for EM2884 (Terratec Cinergy HTC Stick)

2011-12-24 Thread Dennis Sperlich
Hi, I have a Terratec Cinergy HTC Stick an tried the new support for the DVB-C part. It works for SD material (at least for free receivable stations, I tried afair only QAM64), but did not for HD stations (QAM256). I have only access to unencrypted ARD HD, ZDF HD and arte HD (via KabelDeutsch