Re: s5p_mfc and H.264 frame cropping question

2018-10-05 Thread Tomasz Figa
On Fri, Oct 5, 2018 at 5:38 PM Hans Verkuil wrote: > > On 10/05/2018 10:16 AM, Tomasz Figa wrote: > > On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote: > >> > >> On 10/05/2018 05:12 AM, Tomasz Figa wrote: > >>> Hi Hans, > >>> > >>> On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote: > > >>>

Re: s5p_mfc and H.264 frame cropping question

2018-10-05 Thread Hans Verkuil
On 10/05/2018 10:16 AM, Tomasz Figa wrote: > On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote: >> >> On 10/05/2018 05:12 AM, Tomasz Figa wrote: >>> Hi Hans, >>> >>> On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote: Hi all, I'm looking at removing the last users of vidioc_g/s

Re: s5p_mfc and H.264 frame cropping question

2018-10-05 Thread Tomasz Figa
On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote: > > On 10/05/2018 05:12 AM, Tomasz Figa wrote: > > Hi Hans, > > > > On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote: > >> > >> Hi all, > >> > >> I'm looking at removing the last users of vidioc_g/s_crop from the driver > >> and > >> I came acr

Re: s5p_mfc and H.264 frame cropping question

2018-10-04 Thread Hans Verkuil
On 10/05/2018 05:12 AM, Tomasz Figa wrote: > Hi Hans, > > On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote: >> >> Hi all, >> >> I'm looking at removing the last users of vidioc_g/s_crop from the driver and >> I came across vidioc_g_crop in drivers/media/platform/s5p-mfc/s5p_mfc_dec.c. >> >> What

s5p_mfc and H.264 frame cropping question

2018-10-04 Thread Hans Verkuil
Hi all, I'm looking at removing the last users of vidioc_g/s_crop from the driver and I came across vidioc_g_crop in drivers/media/platform/s5p-mfc/s5p_mfc_dec.c. What this really does AFAICS is return the H.264 frame crop as read from the bitstream. This has nothing to do with regular cropping/c