Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-11-20 Thread Sean Young
On Mon, Nov 17, 2014 at 12:59:09PM -0200, Mauro Carvalho Chehab wrote: > Em Sun, 9 Nov 2014 21:35:17 + > Sean Young escreveu: > > > On Thu, Nov 06, 2014 at 08:56:47AM -0500, Andy Walls wrote: > > > On November 6, 2014 8:54:28 AM EST, Andy Walls > > > wrote: > > > >Sean, > > > > > > > >Ir-kb

Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-11-17 Thread Mauro Carvalho Chehab
Em Sun, 9 Nov 2014 21:35:17 + Sean Young escreveu: > On Thu, Nov 06, 2014 at 08:56:47AM -0500, Andy Walls wrote: > > On November 6, 2014 8:54:28 AM EST, Andy Walls > > wrote: > > >Sean, > > > > > >Ir-kbd-i2c was never intended for Tx. > > > > > >You can transmit *short* arbitrary pulse-spac

Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-11-09 Thread Sean Young
On Thu, Nov 06, 2014 at 08:56:47AM -0500, Andy Walls wrote: > On November 6, 2014 8:54:28 AM EST, Andy Walls wrote: > >Sean, > > > >Ir-kbd-i2c was never intended for Tx. > > > >You can transmit *short* arbitrary pulse-space streams with the zilog > >chip, by feeding it a parameter block that has t

Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-11-06 Thread Andy Walls
On November 6, 2014 8:54:28 AM EST, Andy Walls wrote: >On November 6, 2014 8:21:13 AM EST, Sean Young wrote: >>On Thu, Nov 06, 2014 at 11:05:49AM -0200, Mauro Carvalho Chehab wrote: >>> Hi Sean, >>> >>> Em Thu, 06 Nov 2014 12:46:29 + >>> Sean Young escreveu: >>> >>> > On Fri, Oct 31, 2014

Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-11-06 Thread Sean Young
On Thu, Nov 06, 2014 at 11:05:49AM -0200, Mauro Carvalho Chehab wrote: > Hi Sean, > > Em Thu, 06 Nov 2014 12:46:29 + > Sean Young escreveu: > > > On Fri, Oct 31, 2014 at 05:35:41PM +0300, Dan Carpenter wrote: > > > On Fri, Oct 31, 2014 at 04:26:45PM +0200, Aya Mahfouz wrote: > > > > On Fri,

Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-11-06 Thread Mauro Carvalho Chehab
Hi Sean, Em Thu, 06 Nov 2014 12:46:29 + Sean Young escreveu: > On Fri, Oct 31, 2014 at 05:35:41PM +0300, Dan Carpenter wrote: > > On Fri, Oct 31, 2014 at 04:26:45PM +0200, Aya Mahfouz wrote: > > > On Fri, Oct 31, 2014 at 04:06:00PM +0300, Dan Carpenter wrote: > > > > drivers/staging/media/li

Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-11-06 Thread Sean Young
On Fri, Oct 31, 2014 at 05:35:41PM +0300, Dan Carpenter wrote: > On Fri, Oct 31, 2014 at 04:26:45PM +0200, Aya Mahfouz wrote: > > On Fri, Oct 31, 2014 at 04:06:00PM +0300, Dan Carpenter wrote: > > > drivers/staging/media/lirc/lirc_zilog.c > > > 1333 /* Close the IR device */ > > > 1334 static

Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-11-01 Thread Aya Mahfouz
On Fri, Oct 31, 2014 at 05:35:41PM +0300, Dan Carpenter wrote: > On Fri, Oct 31, 2014 at 04:26:45PM +0200, Aya Mahfouz wrote: > > On Fri, Oct 31, 2014 at 04:06:00PM +0300, Dan Carpenter wrote: > > > drivers/staging/media/lirc/lirc_zilog.c > > > 1333 /* Close the IR device */ > > > 1334 static

Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-10-31 Thread Dan Carpenter
On Fri, Oct 31, 2014 at 04:26:45PM +0200, Aya Mahfouz wrote: > On Fri, Oct 31, 2014 at 04:06:00PM +0300, Dan Carpenter wrote: > > drivers/staging/media/lirc/lirc_zilog.c > > 1333 /* Close the IR device */ > > 1334 static int close(struct inode *node, struct file *filep) > > 1335 { > > 13

Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-10-31 Thread Aya Mahfouz
On Fri, Oct 31, 2014 at 04:06:00PM +0300, Dan Carpenter wrote: > Hello Aya Mahfouz, > Hello Dan, > The patch be4aa8157c98: "staging: media: lirc: lirc_zilog.c: replace > custom print macros with dev_* and pr_*" from Oct 26, 2014, leads to > the followi

re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-10-31 Thread Dan Carpenter
Hello Aya Mahfouz, The patch be4aa8157c98: "staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*" from Oct 26, 2014, leads to the following static checker warning: drivers/staging/media/lirc/lirc_zilog.c:1340 close() error: we previously a